1547706 - NSPR version check in configure script and pkg-config differ

Status: NEW

(NSS :: Build, defect, P5)

Description

[Paul Menzel]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:66.0) Gecko/20100101 Firefox/66.0

Steps to reproduce:

Building NSS 3.43 against NSPR 4.12 works fine. But in the resulting pkg-config file, at least NSPR 4.20 is required.

$ less /usr/lib/pkgconfig/nss.pc 
prefix=/usr
exec_prefix=${prefix}
libdir=${prefix}/lib
includedir=${prefix}/include/nss

Name: NSS
Description: Network Security Services
Version: 3.43.0
Requires: nspr >= 4.20
Libs: -L${prefix}/lib -lnss3 -lnssutil3 -lsmime3 -lssl3 -lsoftokn3
Cflags: -I${includedir}

Expected results:

Shouldn’t the configure script then also check that at least NSPR 4.20 is built against.

Comment 1

[J.C. Jones [:jcj] (he/him)]

Note: This will need to go into the release process documentation.

Comment 2

[J.C. Jones [:jcj] (he/him)]

Small brain dump for me later: automation/release/nspr-version.txt is the only place in-tree where NSPR version data is kept. The .pc files are apparently coming from that, so configure should check it, too.

Comment 3

[J.C. Jones [:jcj] (he/him)]

Note: Assuming there's a process fix, we'll need to update https://wiki.mozilla.org/NSS/Release_Management accordingly.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last months and this bug has priority 'P1'.
:beurdouche, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 5

[John Schanck [:jschanck]]

I don't see where we create nss.pc during an NSS build. We have a template in nss/pkg/pkg-config/nss.pc.in, and some Linux distributions (e.g. arch) use this to generate the nss.pc that they ship.

I would take a patch w/ a script to generate nss.pc from the template and the information in automation/release/nspr-version.txt, but I don't think we'll do this ourselves.