Closed Bug 1548011 Opened 2 years ago Closed 1 year ago

Make proxy an optional permission

Categories

(WebExtensions :: General, enhancement, P1)

66 Branch
x86_64
Linux
enhancement

Tracking

(firefox77 fixed)

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: jakub.golebicki, Assigned: mixedpuppy)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

At this point when addon needs a proxy permission it can't be optional.

Some addons support proxy, but do much more, however users who use them need to give blanket proxy permission to the addon and hope nothing bad happens.

It'd appear there's no way for the user to block proxy in the settings that'd block extension, nor is there an option to inform user when proxy is being used.

This situation forces users to pick between security and usability.

Suggestions.

  1. Make Proxy permission optional.
  2. Inform user when proxy is being used.
  3. Give option to permanently block proxy usage, even when enabled by extension.
Product: Firefox → WebExtensions
Flags: needinfo?(mconca)

I believe making the proxy permission optional would accomplish all three objectives listed.

Blocks: 1458585
Flags: needinfo?(mconca)
Priority: -- → P5
Summary: Enhance Proxy Extensions Security. → Make proxy an optional permission

Hi, will this enhancement require manual validation? If yes, please provide some steps to reproduce in order for us to properly verify it and any other resource needed for testing (website, add-on, etc.). Additionally, please set the “qe-verify+” flag. Thanks !

Flags: needinfo?(mconca)

(In reply to Alex Cornestean from comment #2)

Hi, will this enhancement require manual validation? If yes, please provide some steps to reproduce in order for us to properly verify it and any other resource needed for testing (website, add-on, etc.). Additionally, please set the “qe-verify+” flag. Thanks !

No patch for this bug has been submitted, so these questions cannot be answered yet.

Flags: needinfo?(mconca)

I'm transitioning this bug to cover all permissions other than devtools (bug 1606862), which works different than normal permissions.

Those include:

management=Monitor extension usage and manage themes
pkcs11=Provide cryptographic authentication services
proxy=Control browser proxy settings
browsingData=Clear recent browsing history, cookies, and related data
nativeMessaging=Exchange messages with programs other than %S
sessions=Access recently closed tabs
unlimitedStorage=Store unlimited amount of client-side data

Summary: Make proxy an optional permission → Allow remaining simple required permissions work as optional permissions

Also need to ensure we have all optional permissions in test_ext_permissions_api.js

Priority: P5 → P1
Assignee: nobody → mixedpuppy

Sorry for the noise. I jumped the gun here, and am going to do separate bugs for each permission.

Summary: Allow remaining simple required permissions work as optional permissions → Make proxy an optional permission
Pushed by scaraveo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1dde649fe4e0
support proxy as an optional extension permission r=rpl
Pushed by scaraveo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3f4c30f4d2c5
support proxy as an optional extension permission r=rpl
Status: UNCONFIRMED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
Keywords: dev-doc-needed

The following changes have been made:

  • note added to release notes
  • compatibility data updated, see PR6112
  • notes added to the Extension Workshop article on requesting permissions, see PR636

Please let me know if you think further changes are needed.

Flags: needinfo?(mixedpuppy)

thanks!

Flags: needinfo?(mixedpuppy)
You need to log in before you can comment on or make changes to this bug.