1548011 - Make proxy an optional permission

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P1)

Description

[Jakub Gołębicki]

At this point when addon needs a proxy permission it can't be optional.

Some addons support proxy, but do much more, however users who use them need to give blanket proxy permission to the addon and hope nothing bad happens.

It'd appear there's no way for the user to block proxy in the settings that'd block extension, nor is there an option to inform user when proxy is being used.

This situation forces users to pick between security and usability.

Suggestions.

1. Make Proxy permission optional.
2. Inform user when proxy is being used.
3. Give option to permanently block proxy usage, even when enabled by extension.

Comment 1

[Mike Conca [:mconca]]

I believe making the proxy permission optional would accomplish all three objectives listed.

Comment 2

[Alex Cornestean]

Hi, will this enhancement require manual validation? If yes, please provide some steps to reproduce in order for us to properly verify it and any other resource needed for testing (website, add-on, etc.). Additionally, please set the “qe-verify+” flag. Thanks !

Comment 3

[Mike Conca [:mconca]]

(In reply to Alex Cornestean from comment #2)

Hi, will this enhancement require manual validation? If yes, please provide some steps to reproduce in order for us to properly verify it and any other resource needed for testing (website, add-on, etc.). Additionally, please set the “qe-verify+” flag. Thanks !

No patch for this bug has been submitted, so these questions cannot be answered yet.

Comment 4

[Shane Caraveo (:mixedpuppy)]

I'm transitioning this bug to cover all permissions other than devtools (bug 1606862), which works different than normal permissions.

Those include:

management=Monitor extension usage and manage themes
pkcs11=Provide cryptographic authentication services
proxy=Control browser proxy settings
browsingData=Clear recent browsing history, cookies, and related data
nativeMessaging=Exchange messages with programs other than %S
sessions=Access recently closed tabs
unlimitedStorage=Store unlimited amount of client-side data

Comment 5

[Shane Caraveo (:mixedpuppy)]

Also need to ensure we have all optional permissions in test_ext_permissions_api.js

Comment 6

[Shane Caraveo (:mixedpuppy)]

Sorry for the noise. I jumped the gun here, and am going to do separate bugs for each permission.

Comment 7

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1548011 support proxy as an optional extension permission

Comment 8

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=182c6ffa29082fff0d3fc685a7136cefd82d986d

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1dde649fe4e0
support proxy as an optional extension permission r=rpl

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f4c30f4d2c5
support proxy as an optional extension permission r=rpl

Comment 11

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/3f4c30f4d2c5

Comment 12

[Richard Bloor]

The following changes have been made:

• note added to release notes
• compatibility data updated, see PR6112
• notes added to the Extension Workshop article on requesting permissions, see PR636

Please let me know if you think further changes are needed.

Comment 13

[Shane Caraveo (:mixedpuppy)]

thanks!