1548179 - Determine whether we still need test_build

Status: RESOLVED FIXED

(NSS :: Test, enhancement, P2)

Description

[Martin Thomson [:mt:]]

Bug 1317928 introduced a test_build flag to our builds that did two things: statically link softoken and build two sets of test files in lib/freebl. These builds are run separately to other builds, so that these tests can be run.

There isn't a lot of rationale documented for this arrangement and as far as I can tell these tests work without the additional static linking that test_build=1 triggered.

We should investigate whether these tests can be built and run during regular builds. If they can be integrated into the build, we save a fairly significant amount of machine time.

Comment 1

[Kevin Jacobs [:kjacobs]]

MPI/Freebl tests work with and without the --test option. I think we can safely remove it and leave only the --static instead (see https://treeherder.mozilla.org/#/jobs?repo=nss-try&revision=4a00abf47f4e6755d48cbe9106537748956e1866)

One question: Do we still want taskcluster to exercise the "Test" (aka "Static") group? If so, with what test coverage? I suggest we move MPI tests out from under the Static/Test group (they should not only be exercised from Linux builds anyway...), then do one of the following:

1. Leave the Static Build task but run no tests under it
2. Remove Static Build and subtests entirely

I'm leaning towards 2 and will submit a patch accordingly.

Comment 2

[Kevin Jacobs [:kjacobs]]

Attachment: Bug 1548179 - Remove --test (test_build) option from build.sh (replaced by --static), remove Test builds from taskcluster since we exercise pk11_gtest and mpi_gtests in non-static builds already. r=mt

Comment 3

[J.C. Jones [:jcj] (he/him)]

https://hg.mozilla.org/projects/nss/rev/89def146bde6d8ef667e43cadc9c1c90dc84220a