Perma TEST-UNEXPECTED-FAIL | devtools/client/inspector/rules/test/browser_rules_inactive_css_flexbox.js | "align-self:stretch" is inactive - when Gecko 68 merges to Beta on 2019-05-13

VERIFIED FIXED in Firefox 68

Status

defect
P1
normal
VERIFIED FIXED
2 months ago
Last month

People

(Reporter: apavel, Assigned: miker)

Tracking

(Blocks 1 bug, Regression, {regression})

unspecified
Firefox 68
Dependency tree / graph

Firefox Tracking Flags

(geckoview66 unaffected, firefox-esr60 unaffected, firefox66 unaffected, firefox67 unaffected, firefox68+ verified)

Details

Attachments

(2 attachments)

Reporter

Description

2 months ago

[Tracking Requested - why for this release]:

Central as Beta simulation

Treeherder link: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=f8f9af2af8d8d6f59cb12b0281781d60632dcfdb&selectedJob=243897913

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=243897913&repo=try&lineNumber=11424

11:23:58 INFO - TEST-START | devtools/client/inspector/rules/test/browser_rules_inactive_css_flexbox.js
11:23:58 INFO - GECKO(10232) | ++DOCSHELL 000001E1B2991800 == 4 [pid = 1436] [id = {d0457f37-ad39-45b6-be05-c8a9b10f4cdd}]
11:23:58 INFO - GECKO(10232) | ++DOMWINDOW == 13 (000001E1B1039B60) [pid = 1436] [serial = 387] [outer = 0000000000000000]
11:23:58 INFO - GECKO(10232) | ++DOMWINDOW == 14 (000001E1B420A800) [pid = 1436] [serial = 388] [outer = 000001E1B1039B60]

11:24:00 INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/rules/test/browser_rules_inactive_css_flexbox.js | "align-self:stretch" is inactive -
11:24:00 INFO - Stack trace:
11:24:00 INFO - chrome://mochikit/content/browser-test.js:test_ok:1314
11:24:00 INFO - chrome://mochitests/content/browser/devtools/client/inspector/rules/test/head.js:checkDeclarationIsInactive:703
11:24:00 INFO - chrome://mochitests/content/browser/devtools/client/inspector/rules/test/head.js:runInactiveCSSTests:802
11:24:00 INFO - Not taking screenshot here: see the one that was previously logged
11:24:00 INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/rules/test/browser_rules_inactive_css_flexbox.js | "align-self:stretch" has a warning - Got 0, expected 1
11:24:00 INFO - Stack trace:
11:24:00 INFO - chrome://mochikit/content/browser-test.js:test_is:1325
11:24:00 INFO - chrome://mochitests/content/browser/devtools/client/inspector/rules/test/head.js:checkDeclarationIsInactive:704
11:24:00 INFO - chrome://mochitests/content/browser/devtools/client/inspector/rules/test/head.js:runInactiveCSSTests:802
11:24:00 INFO - Not taking screenshot here: see the one that was previously logged
11:24:00 INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/rules/test/browser_rules_inactive_css_flexbox.js | The warning on "align-self:stretch" is correct - Got undefined, expected “align-self” has no effect on this element since it’s not a grid or flex item (try adding “display:grid”, “display:flex”, “display:inline-grid” or “display:inline-flex” to the item’s parent)
11:24:00 INFO - Stack trace:
11:24:00 INFO - chrome://mochikit/content/browser-test.js:test_is:1325
11:24:00 INFO - chrome://mochitests/content/browser/devtools/client/inspector/rules/test/head.js:checkDeclarationIsInactive:707
11:24:00 INFO - chrome://mochitests/content/browser/devtools/client/inspector/rules/test/head.js:runInactiveCSSTests:802
11:24:00 INFO - Selecting the node for '.item-2'
11:24:00 INFO - TEST-PASS | devtools/client/inspector/rules/test/browser_rules_inactive_css_flexbox.js | order:2 is active -
11:24:00 INFO - TEST-PASS | devtools/client/inspector/rules/test/browser_rules_inactive_css_flexbox.js | order:2 has no warnings -
11:24:00 INFO - TEST-PASS | devtools/client/inspector/rules/test/browser_rules_inactive_css_flexbox.js | flex-basis:auto is active -
11:24:00 INFO - TEST-PASS | devtools/client/inspector/rules/test/browser_rules_inactive_css_flexbox.js | flex-basis:auto has no warnings -
11:24:00 INFO - TEST-PASS | devtools/client/inspector/rules/test/browser_rules_inactive_css_flexbox.js | flex-grow:1 is active -
11:24:00 INFO - TEST-PASS | devtools/client/inspector/rules/test/browser_rules_inactive_css_flexbox.js | flex-grow:1 has no warnings -
11:24:00 INFO - TEST-PASS | devtools/client/inspector/rules/test/browser_rules_inactive_css_flexbox.js | flex-shrink:1 is active -
11:24:00 INFO - TEST-PASS | devtools/client/inspector/rules/test/browser_rules_inactive_css_flexbox.js | flex-shrink:1 has no warnings -
11:24:00 INFO - Not taking screenshot here: see the one that was previously logged
11:24:00 INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/rules/test/browser_rules_inactive_css_flexbox.js | "flex-direction:row" is inactive -

Mike, this is fixed by https://bugzilla.mozilla.org/show_bug.cgi?id=1306054#c31 however it did not reach central before the beta sims were done. I still filed a bug so you know that this is an issue too.

Flags: needinfo?(mratcliffe)

Not a big issue as we backed the bug about because we need to switch over to Fluent in order to properly format our "tooltips."

We used to wait for markupmutation to prevent this but the event doesn't always appear on try. I will just switch to another, slightly earlier event.

Assignee: nobody → mratcliffe
Status: NEW → ASSIGNED
Flags: needinfo?(mratcliffe)
OS: Unspecified → All
Priority: -- → P3
Hardware: Unspecified → All

Given the backout I guess this won't be an issue for the merge next week.

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Comment hidden (Intermittent Failures Robot)
Status: VERIFIED → REOPENED
Flags: needinfo?(mratcliffe)
Priority: P3 → P1
Resolution: FIXED → ---
Summary: Perma TEST-UNEXPECTED-FAIL | devtools/client/inspector/rules/test/browser_rules_inactive_css_flexbox.js | "align-self:stretch" is inactive - when Gecko 68 merges to Beta on 2019-05-06 → Perma TEST-UNEXPECTED-FAIL | devtools/client/inspector/rules/test/browser_rules_inactive_css_flexbox.js | "align-self:stretch" is inactive - when Gecko 68 merges to Beta on 2019-05-13
Comment hidden (Intermittent Failures Robot)

Hmmm... maybe we should stop listening for events and start adding some puppeteer style methods. I am guessing we will eventually be using puppeteer for our tests anyhow.

Flags: needinfo?(mratcliffe)

Comment 11

Last month
Pushed by mratcliffe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f12becef5ac1
Fix browser_rules_inactive_css_(flexbox|grid).js on Beta r=jdescottes
Reporter

Comment 12

Last month
bugherder
Status: REOPENED → RESOLVED
Closed: 2 months agoLast month
Resolution: --- → FIXED
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
You need to log in before you can comment on or make changes to this bug.