1548240 - Perma TEST-UNEXPECTED-FAIL | devtools/client/inspector/rules/test/browser_rules_inactive_css_flexbox.js | "align-self:stretch" is inactive - when Gecko 68 merges to Beta on 2019-05-13

Status: VERIFIED FIXED

(DevTools :: Inspector: Rules, defect, P1)

Description

[Andreea Pavel [:apavel]]

[Tracking Requested - why for this release]:

Central as Beta simulation

Treeherder link: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=f8f9af2af8d8d6f59cb12b0281781d60632dcfdb&selectedJob=243897913

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=243897913&repo=try&lineNumber=11424

11:23:58 INFO - TEST-START | devtools/client/inspector/rules/test/browser_rules_inactive_css_flexbox.js
11:23:58 INFO - GECKO(10232) | ++DOCSHELL 000001E1B2991800 == 4 [pid = 1436] [id = {d0457f37-ad39-45b6-be05-c8a9b10f4cdd}]
11:23:58 INFO - GECKO(10232) | ++DOMWINDOW == 13 (000001E1B1039B60) [pid = 1436] [serial = 387] [outer = 0000000000000000]
11:23:58 INFO - GECKO(10232) | ++DOMWINDOW == 14 (000001E1B420A800) [pid = 1436] [serial = 388] [outer = 000001E1B1039B60]

11:24:00 INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/rules/test/browser_rules_inactive_css_flexbox.js | "align-self:stretch" is inactive -
11:24:00 INFO - Stack trace:
11:24:00 INFO - chrome://mochikit/content/browser-test.js:test_ok:1314
11:24:00 INFO - chrome://mochitests/content/browser/devtools/client/inspector/rules/test/head.js:checkDeclarationIsInactive:703
11:24:00 INFO - chrome://mochitests/content/browser/devtools/client/inspector/rules/test/head.js:runInactiveCSSTests:802
11:24:00 INFO - Not taking screenshot here: see the one that was previously logged
11:24:00 INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/rules/test/browser_rules_inactive_css_flexbox.js | "align-self:stretch" has a warning - Got 0, expected 1
11:24:00 INFO - Stack trace:
11:24:00 INFO - chrome://mochikit/content/browser-test.js:test_is:1325
11:24:00 INFO - chrome://mochitests/content/browser/devtools/client/inspector/rules/test/head.js:checkDeclarationIsInactive:704
11:24:00 INFO - chrome://mochitests/content/browser/devtools/client/inspector/rules/test/head.js:runInactiveCSSTests:802
11:24:00 INFO - Not taking screenshot here: see the one that was previously logged
11:24:00 INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/rules/test/browser_rules_inactive_css_flexbox.js | The warning on "align-self:stretch" is correct - Got undefined, expected “align-self” has no effect on this element since it’s not a grid or flex item (try adding “display:grid”, “display:flex”, “display:inline-grid” or “display:inline-flex” to the item’s parent)
11:24:00 INFO - Stack trace:
11:24:00 INFO - chrome://mochikit/content/browser-test.js:test_is:1325
11:24:00 INFO - chrome://mochitests/content/browser/devtools/client/inspector/rules/test/head.js:checkDeclarationIsInactive:707
11:24:00 INFO - chrome://mochitests/content/browser/devtools/client/inspector/rules/test/head.js:runInactiveCSSTests:802
11:24:00 INFO - Selecting the node for '.item-2'
11:24:00 INFO - TEST-PASS | devtools/client/inspector/rules/test/browser_rules_inactive_css_flexbox.js | order:2 is active -
11:24:00 INFO - TEST-PASS | devtools/client/inspector/rules/test/browser_rules_inactive_css_flexbox.js | order:2 has no warnings -
11:24:00 INFO - TEST-PASS | devtools/client/inspector/rules/test/browser_rules_inactive_css_flexbox.js | flex-basis:auto is active -
11:24:00 INFO - TEST-PASS | devtools/client/inspector/rules/test/browser_rules_inactive_css_flexbox.js | flex-basis:auto has no warnings -
11:24:00 INFO - TEST-PASS | devtools/client/inspector/rules/test/browser_rules_inactive_css_flexbox.js | flex-grow:1 is active -
11:24:00 INFO - TEST-PASS | devtools/client/inspector/rules/test/browser_rules_inactive_css_flexbox.js | flex-grow:1 has no warnings -
11:24:00 INFO - TEST-PASS | devtools/client/inspector/rules/test/browser_rules_inactive_css_flexbox.js | flex-shrink:1 is active -
11:24:00 INFO - TEST-PASS | devtools/client/inspector/rules/test/browser_rules_inactive_css_flexbox.js | flex-shrink:1 has no warnings -
11:24:00 INFO - Not taking screenshot here: see the one that was previously logged
11:24:00 INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/rules/test/browser_rules_inactive_css_flexbox.js | "flex-direction:row" is inactive -

Mike, this is fixed by https://bugzilla.mozilla.org/show_bug.cgi?id=1306054#c31 however it did not reach central before the beta sims were done. I still filed a bug so you know that this is an issue too.

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Not a big issue as we backed the bug about because we need to switch over to Fluent in order to properly format our "tooltips."

We used to wait for markupmutation to prevent this but the event doesn't always appear on try. I will just switch to another, slightly earlier event.

Comment 2

[Julien Cristau [:jcristau]]

Given the backout I guess this won't be an issue for the merge next week.

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified gone https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=06c4f5085c3e2519a7e9b209737b93e80ac951b8

Comment 4

[Intermittent Failures Robot]

82 failures in 360 pushes (0.228 failures/push) were associated with this bug yesterday.

Repository breakdown:

• try: 82

Platform breakdown:

• osx-10-10: 6
• linux64: 12
• osx-10-10-shippable: 6
• macosx64-devedition: 6
• windows7-32: 5
• windows10-64: 6
• linux32-devedition: 5
• linux64-shippable: 5
• linux64-devedition: 5
• windows10-64-devedition: 6
• linux32-shippable: 5
• windows10-64-shippable: 5
• windows7-32-devedition: 5
• windows7-32-shippable: 5

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1548240&startday=2019-05-11&endday=2019-05-11&tree=all

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This fails again since bug 1306054 relanded: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=4566ca9e5b9b57263f488793c30c67494161dd10&selectedJob=245968993

Comment 6

[Intermittent Failures Robot]

83 failures in 4705 pushes (0.018 failures/push) were associated with this bug in the last 7 days.

This is the #24 most frequent failure this week.

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **

Repository breakdown:

• try: 83

Platform breakdown:

• linux64: 12
• osx-10-10: 6
• osx-10-10-shippable: 6
• macosx64-devedition: 7
• windows7-32: 5
• windows10-64: 6
• linux64-devedition: 5
• linux64-shippable: 5
• linux32-devedition: 5
• windows7-32-devedition: 5
• linux32-shippable: 5
• windows10-64-shippable: 5
• windows10-64-devedition: 6
• windows7-32-shippable: 5

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1548240&startday=2019-05-06&endday=2019-05-12&tree=all

Comment 7

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Hmmm... maybe we should stop listening for events and start adding some puppeteer style methods. I am guessing we will eventually be using puppeteer for our tests anyhow.

Comment 8

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1548240 - Disable test temporarily

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4750c8223f65
Disable test temporarily r=pbro

Comment 10

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1548240 - Fix browser_rules_inactive_css_(flexbox|grid).js on Beta r?jdescottes!

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f12becef5ac1
Fix browser_rules_inactive_css_(flexbox|grid).js on Beta r=jdescottes

Comment 12

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/4750c8223f65
https://hg.mozilla.org/mozilla-central/rev/f12becef5ac1

Comment 13

[Intermittent Failures Robot]

17 failures in 746 pushes (0.023 failures/push) were associated with this bug yesterday.

Repository breakdown:

• try: 1
• mozilla-beta: 16

Platform breakdown:

• linux32-shippable: 3
• linux64-shippable: 2
• linux32-devedition: 2
• linux64-devedition: 2
• windows7-32-shippable: 2
• windows10-64-shippable: 2
• windows7-32: 1
• windows10-64-devedition: 1
• windows7-32-devedition: 1
• osx-10-10-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1548240&startday=2019-05-13&endday=2019-05-13&tree=all

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed with today's beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunning%2Cpending%2Crunnable&revision=9365d3ebbb4bf3b2ad5efa4b712b2707bf45b107

Comment 15

[Intermittent Failures Robot]

19 failures in 4658 pushes (0.004 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 3
• mozilla-beta: 16

Platform breakdown:

• linux32-shippable: 4
• windows7-32: 1
• linux64-shippable: 2
• linux32-devedition: 3
• linux64-devedition: 2
• windows10-64-devedition: 1
• windows7-32-shippable: 2
• windows10-64-shippable: 2
• windows7-32-devedition: 1
• osx-10-10-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1548240&startday=2019-05-13&endday=2019-05-19&tree=all