Closed Bug 1548303 Opened 2 years ago Closed 2 years ago

It is very difficult to resize Picture-in-Picture window by mouse dragging

Categories

(Toolkit :: Video/Audio Controls, defect, P2)

68 Branch
x86_64
Windows 10
defect

Tracking

()

VERIFIED FIXED
mozilla68
Tracking Status
firefox-esr60 --- unaffected
firefox66 --- unaffected
firefox67 --- unaffected
firefox68 --- verified

People

(Reporter: alice0775, Assigned: mconley)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Sometimes, the mouse pointer will change to resizer cursor, and I can resize the PiP window by mouse pointer.
But, sometime, it does not. The cursor would not change.

Almost impossible.

Steps To Reproduce:

  1. Enable Picture in Picture media.videocontrols.picture-in-picture.enabled=true if not
  2. Play and Video
  3. Enter Picture in Picture mode
  4. Try to resize the Pip window by mouse

Actual Results:
The mouse pointer would not be changed to resizer cursor on the PiP window border.
Sometimes, the mouse pointer is changed to resizer cursor. But the pointer will be immediately changed to normal cursor.
So, I cannot resize the window.

Expected Results:
At least, A mouse pointer should react like main window.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=32552726554321d35a8c18224343fe73ece324c2&tochange=0930049c0ca984c909d11ba2853ef6d96e43e242

Regressed by: 0930049c0ca984c909d11ba2853ef6d96e43e242 Mike Conley — Bug 1534389 - Send normal mouse events when cursor is over a draggable region on Windows. r=jmathies

:mconley,
Your patch seems to cause the regression. Can you please look into this?

Flags: needinfo?(mconley)

Yes, I've added it to my queue - thank you for filing.

Blocks: 1527926
Flags: needinfo?(mconley)
Priority: -- → P2

This is made easier by making the window-dragging region inset by 5px on each side.

Depends on D30100

Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/93e59a14b907
Make it easier to resize the Picture-in-Picture player window. r=dthayer
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Assignee: nobody → mconley

I have the same problem with resizing the whole browser window.
Is this related and fixed as well?

Blocks: 1549972
Flags: qe-verify+

Removing the "qe-verify+ tag, considering the newly added bugs.

Also, Considering that the fix did not fix the reporter's issue, should it not be backed out?
This also applies to the clone of this bug: bug 1549972.

Flags: qe-verify+ → needinfo?(mconley)

Build ID 20190626093633
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0

Verified as fixed on the latest Nightly build on Windows 10.

Status: RESOLVED → VERIFIED

The original fix was backed out of beta 68, and I'm currently investigating the issue in bug 1557710.

Flags: needinfo?(mconley)
You need to log in before you can comment on or make changes to this bug.