1548478 - Fluent warnings about missing strings

Status: RESOLVED FIXED

(Firefox :: Messaging System, enhancement, P2)

Description

[Andrei Oprea [:andreio]]

Attachment: Screenshot 2019-05-02 at 11.29.01.png

tabbrowser.js uses fluent for translations and has a mutation observer listening for changes. When we insert the FxA message it tries to translate it but it's doesn't know about asrouter.ftl and reports the strings as missing.
This isn't causing any issues, BookmarkPanelHub correctly translates the message but we get a warning in the console.
We should (maybe) have the strings in tabbrowser.js and not do the translations.

[0] https://searchfox.org/mozilla-central/rev/7944190ad1668a94223b950a19f1fffe8662d6b8/browser/base/content/tabbrowser.js#4757

Comment 1

[Andrei Oprea [:andreio]]

Attachment: Bug 1548478 - Fix fluent warnings about missing translations for Bookmark Panel messages

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17f72de310de
Fix fluent warnings about missing translations for Bookmark Panel messages r=zbraniecki

Comment 3

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/17f72de310de