1548510 - Some profiler cleanups

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Jan de Mooij [:jandem]]

• These functions do the same thing AFAICT so let's merge them:

https://searchfox.org/mozilla-central/rev/7944190ad1668a94223b950a19f1fffe8662d6b8/js/src/vm/GeckoProfiler.cpp#263

https://searchfox.org/mozilla-central/rev/7944190ad1668a94223b950a19f1fffe8662d6b8/js/src/jit/JitcodeMap.cpp#280

• GeckoProfilerRuntime::strings is an ExclusiveData<> but it seems to be only accessed on the main thread. I want to put in an assert for this and then remove the locking.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1548510 part 1 - Remove unnecessary GeckoProfilerRuntime::strings lock. r?jonco!

This lock was necessary when the JITs used these strings (off-thread Ion compilation),
but now the lock was just adding overhead to each script we finalize etc.

This replaces ExclusiveData<> with MainThreadData<> to assert on-main-thread in debug
builds.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1548510 part 2 - Deduplicate GeckoProfilerRuntime::allocProfileString and JitcodeGlobalEntry::createScriptString. r?jonco!

These functions did the same thing in a slightly different way.

Depends on D29798

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59086433eca1
part 1 - Remove unnecessary GeckoProfilerRuntime::strings lock. r=jonco
https://hg.mozilla.org/integration/autoland/rev/39af0d6ccd3d
part 2 - Deduplicate GeckoProfilerRuntime::allocProfileString and JitcodeGlobalEntry::createScriptString. r=jonco

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/59086433eca1
https://hg.mozilla.org/mozilla-central/rev/39af0d6ccd3d