1548563 - move symbol file logic into the moz.build frontend

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: Bug 1548563 - move symbol file logic into the moz.build frontend; r=#build

This way compilation backends don't all have to figure out the right way
to handle symbol files.

Comment 2

[Nathan Froyd [:froydnj]]

ni? for questions in the phab review.

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Responded in phabricator.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e785d870458
move symbol file logic into the moz.build frontend; r=firefox-build-system-reviewers,chmanchester

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/3e785d870458

Comment 6

[Florin Strugariu [:Bebe]]

== Change summary for alert #21043 (as of Wed, 22 May 2019 20:17:39 GMT) ==

Improvements:

46% raptor-tp6m-facebook-geckoview-cold fcp android-hw-p2-8-0-android-aarch64 pgo 1,192.50 -> 642.33
45% raptor-tp6m-facebook-geckoview-cold fcp android-hw-p2-8-0-android-aarch64 opt 1,221.83 -> 674.42
44% raptor-tp6m-instagram-geckoview-cold fcp android-hw-p2-8-0-android-aarch64 pgo 397.50 -> 221.08
44% raptor-tp6m-instagram-geckoview-cold fcp android-hw-p2-8-0-android-aarch64 opt 404.42 -> 226.08
40% raptor-tp6m-facebook-geckoview-cold android-hw-p2-8-0-android-aarch64 pgo 1,444.50 -> 861.82
40% raptor-tp6m-reddit-geckoview loadtime android-hw-p2-8-0-android-aarch64 opt 1,152.71 -> 696.83
37% raptor-tp6m-facebook-geckoview-cold android-hw-p2-8-0-android-aarch64 opt 1,497.51 -> 937.46
36% raptor-tp6m-instagram-geckoview-cold android-hw-p2-8-0-android-aarch64 pgo 658.48 -> 424.75
35% raptor-tp6m-instagram-geckoview-cold android-hw-p2-8-0-android-aarch64 opt 665.39 -> 429.22
27% raptor-tp6m-instagram-geckoview-cold fcp android-hw-g5-7-0-arm7-api-16 opt 649.92 -> 471.58
27% raptor-tp6m-instagram-geckoview-cold fcp android-hw-g5-7-0-arm7-api-16 pgo 634.25 -> 465.50
26% raptor-tp6m-facebook-geckoview-cold loadtime android-hw-p2-8-0-android-aarch64 pgo 2,367.96 -> 1,762.75
23% raptor-tp6m-facebook-geckoview-cold loadtime android-hw-p2-8-0-android-aarch64 opt 2,410.71 -> 1,861.92
22% raptor-tp6m-instagram-geckoview-cold android-hw-g5-7-0-arm7-api-16 opt 1,052.08 -> 822.67
21% raptor-tp6m-facebook-geckoview-cold fcp android-hw-g5-7-0-arm7-api-16 opt 1,793.12 -> 1,415.83
21% raptor-tp6m-instagram-geckoview-cold android-hw-g5-7-0-arm7-api-16 pgo 1,018.32 -> 806.18
18% raptor-tp6m-facebook-geckoview-cold android-hw-g5-7-0-arm7-api-16 opt 2,239.86 -> 1,827.06
13% raptor-tp6m-facebook-geckoview-cold loadtime android-hw-g5-7-0-arm7-api-16 opt 3,607.29 -> 3,121.67
13% raptor-tp6m-facebook-geckoview-cold loadtime android-hw-g5-7-0-arm7-api-16 pgo 3,455.98 -> 3,017.33
9% raptor-tp6m-instagram-geckoview-cold loadtime android-hw-p2-8-0-android-aarch64 pgo 2,285.62 -> 2,072.83
8% raptor-tp6m-instagram-geckoview-cold loadtime android-hw-p2-8-0-android-aarch64 opt 2,330.12 -> 2,140.67
6% raptor-tp6m-instagram-geckoview-cold loadtime android-hw-g5-7-0-arm7-api-16 pgo 3,257.10 -> 3,070.83

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=21043