1548623 - Don't cancel content JS from interrupt callback when recording/replaying

Status: RESOLVED FIXED

(Core Graveyard :: Web Replay, defect)

Description

[Brian Hackett [Laid off!]]

When recording/replaying the interrupt callback runs at non-deterministic points, so we disallow recorded events from occurring here. As for the logic to paint from the interrupt callback, the logic to cancel content JS from the interrupt callback should be disabled as well when recording/replaying.

Comment 1

[Jim Porter (:squib)]

Isn't this already the case? The interrupt callback for XPCJSContext never does anything if we're recording/replaying: https://searchfox.org/mozilla-central/rev/b59a99943de4dd314bae4e44ab43ce7687ccbbec/js/xpconnect/src/XPCJSContext.cpp#593-595

Comment 2

[Brian Hackett [Laid off!]]

Attachment: Bug 1548623 - Avoid performing recorded operations in the interrupt callback, r=smaug.

Comment 3

[Jim Porter (:squib)]

Ah, good catch! I don't recall seeing that check for force-painting when I wrote my patch, but maybe I just glossed over it...

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/da538647fa04
Avoid performing recorded operations in the interrupt callback, r=smaug.

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/da538647fa04