Closed Bug 1548686 Opened 6 years ago Closed 6 years ago

don't add RemoteDecoderModule in PDMFactory::CreatePDMs if e10s is off

Categories

(Core :: Audio/Video: Playback, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: mjf, Assigned: mjf)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.

When enabling Vorbis decoding on RDD, 1proc tests will fail because RDD will not return a decoder if not running on the content process. However, because Vorbis decoding on RDD is on, the AgnosticDecoder answer that it does not support Vorbis. We need to check to make sure e10s is on/off when deciding which decoder module (Agnostic or Remote) will support Vorbis.

Assignee: nobody → mfroman
Blocks: RDD
Priority: -- → P2

This can cause 1proc tests to fail because no decoder ends up supporting
a format. The particular case was enabling Vorbis decoding on RDD.

Pushed by mfroman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/514ed4bfb0bd only add RemoteDecoderModule in CreatePDMs if e10s. r=jya
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Regressions: 1548858
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: