154883 - Need to support session printing APIs for OS X

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: Mac, defect)

Description

[Conrad Carlen (not reading bugmail)]

If the non-Gecko printing in an embedding app is using session-based APIs, the
two models do not mix well.

Comment 1

[Conrad Carlen (not reading bugmail)]

Attachment: patch to impl printing with session APIs

Pretty much what I discussed with Rod. There is an iface, nsIPrintSession,
which does nothing by itself but can be subclassed by a platform impl. It is
owned by the top-level printing code because the lifespan of a session is most
clearly defined at that level. Built and tested on Mac Carbon & Windows. There
may be some platform-specific gfx factory code that needs filling in - I can
build all the tier-1 platforms to make sure.

Comment 2

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 90496 [details] [diff] [review]
patch to impl printing with session APIs

r=pink w/ minor comments

+  *aPMPageFormat = mPageFormat;
+  //OSStatus status = ::PMRetain(*aPMPageFormat);
+  OSStatus status = noErr;

remove the commented code as we discussed, line 201 as well.

add a comment as we discussed in the XP print session impl indicating its use
for future expansion of XP routines on the session api.

+  // The out param has a ref count of 1 on return.

Note also that the caller is responsible for releasing.

+  OSStatus CreateDefaultPageFormat(PMPrintSession aSession, PMPageFormat&
outFormat);

I swing back and forth on  using refs for out params. While you don't have to
check for null, it slightly complicates reading of the calling code because
there is nothing explicit to indicate which value is being filled in, as an
explicit |&foo| would. I can go either way, just noting for comment.

Comment 3

[Conrad Carlen (not reading bugmail)]

Attachment: patch for MOZILLA_1_0_BRANCH

The trunk patch needed some conflict resolution and to be re-tested because bug
151628 is not yet on the branch. That bug is in the process of getting adt
approval. Once that goes in, the trunk patch should apply without conflict and
is the preferable patch. I'm just putting this patch here to allow Mac
embedding clients to be able to test the patch in the meanwhile (they're the
only ones seeing problems).

Comment 4

[Mike Pinkerton (not reading bugmail)]

this fixes the crash issues our embeddor had, it should go onto the branch asap
once it gets sr'd

cc'ing sfraser for sr

Comment 5

[Simon Fraser [no longer active]]

Comment on attachment 90673 [details] [diff] [review]
patch for MOZILLA_1_0_BRANCH

Comments:

Index: gfx/macbuild/GFXComponentConfig.h
 #if TARGET_CARBON
-// we can't use the carbon printing session APIs
-#define PM_USE_SESSION_APIS 0
+#define PM_USE_SESSION_APIS 1
 #endif

You can just remove these lines. PM_USE_SESSION_APIS is on by default in the
headers.

sr=sfraser

Comment 6

[Asa Dotzler [:asa]]

Comment on attachment 90496 [details] [diff] [review]
patch to impl printing with session APIs

a=asa (on behalf of drivers) for checkin to the 1.1 trunk.

Comment 7

[Conrad Carlen (not reading bugmail)]

Fixed. Note that, until bug 157129 is fixed, Print Preview is not working.
Hopefully, that will be in before Monday's verif builds in order to verif this.

Comment 8

[chris hofmann]

Comment on attachment 90673 [details] [diff] [review]
patch for MOZILLA_1_0_BRANCH

ok, trunk and branch approval.	add the fixed1.0.1 keyword after checking in on
the branch.

Comment 9

[Paul Wyskoczka]

Adding adt1.0.1+ on behalf of the adt.  Please check this fix into the Mozilla
1.0 branch.

Comment 10

[Conrad Carlen (not reading bugmail)]

Checked into branch.

Comment 11

[sujay]

verified that printing works fine in Mac OSX 7/17 branch build.

I will let Mdunn close this bug out.

Comment 12

[Jaime Rodriguez, Jr.]

mdunn: pls verify this as fixed on the 1.0 branch, then replace the "fixed1.0.1"
keyword, with "verified1.0.1". thanks!

Comment 13

[Michael Dunn]

to ashish for verification