Closed
Bug 1548861
Opened 5 years ago
Closed 5 years ago
Update cache and storage with edits to password fields after generation
Categories
(Toolkit :: Password Manager, enhancement, P1)
Toolkit
Password Manager
Tracking
()
VERIFIED
FIXED
mozilla70
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | verified |
People
(Reporter: MattN, Assigned: MattN)
References
Details
(Whiteboard: [passwords:generation] [skyline])
Attachments
(3 files)
If a user edits a field we filled with a generated password, propagate the user edits to login storage to ensure the resulting password is saved.
We should consider only looking for user edits with isTrusted:true to ignore mungeing done by the site for presentation purposes only.
|
Assignee | |
Updated•5 years ago
|
Flags: qe-verify+
|
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → MattN+bmo
Status: NEW → ASSIGNED
|
||
Updated•5 years ago
|
Whiteboard: [skyline]
|
|
Assignee | |
Updated•5 years ago
|
Whiteboard: [skyline] → [passwords:generation] [skyline]
|
|
Assignee | |
Updated•5 years ago
|
status-firefox70:
--- → affected
|
|
Assignee | |
Updated•5 years ago
|
Summary: Update storage with edits to password fields after generation (when there were no saved logins for the site) → Update storage with edits to password fields after generation (after we auto-saved)
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
Summary: Update storage with edits to password fields after generation (after we auto-saved) → Update cache and storage with edits to password fields after generation
|
|
Assignee | |
Updated•5 years ago
|
Priority: P2 → P1
|
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
Depends on D38968
|
|
Assignee | |
Comment 3•5 years ago
|
||
No UI will be shown once saving is disabled for the site but that may happen after a generated password is already filled.
|
||
Updated•5 years ago
|
Attachment #9079922 -
Attachment description: Bug 1548861 - Update cache with edits to password fields after generation. → Bug 1548861 - Update cache with edits to password fields after generation. r=sfoster
|
|
||
Updated•5 years ago
|
Attachment #9079923 -
Attachment description: Bug 1548861 - Update storage with edits to password fields after generation → Bug 1548861 - Update storage with edits to password fields after generation. r=sfoster
Pushed by mozilla@noorenberghe.ca: https://hg.mozilla.org/integration/autoland/rev/4bdf526194b2 Don't prompt to save generated passwords if saving is disabled for the site. r=sfoster https://hg.mozilla.org/integration/autoland/rev/8723fe0aaad9 Update cache with edits to password fields after generation. r=sfoster https://hg.mozilla.org/integration/autoland/rev/f4fb2058c3e9 Update storage with edits to password fields after generation. r=sfoster
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4bdf526194b2
https://hg.mozilla.org/mozilla-central/rev/8723fe0aaad9
https://hg.mozilla.org/mozilla-central/rev/f4fb2058c3e9
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
|
||
Updated•5 years ago
|
|
||
Comment 6•5 years ago
|
||
Verified - Fixed on latest Beta 70.0b3 (64-bit) on Windows 10 x64 and Mac OS 10.14.
- Generated Passwords are saved in cache after edits -> clicking out of the password field will trigger the auto-save
- Generated Password are correctly updated in about:logins after editing
- Deleting the edited generated password entry in about:logins will not delete it from cache storage -> user can fill in again the same generated (edited) password in the field in the same browser session
- Editing and auto-save for an already saved generated password is not possible for the sites blocked in about:preferences#privacy
You need to log in
before you can comment on or make changes to this bug.
Description
•