1548929 - Spoc end point fetch failures affect spocs state

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Punam Dahiya [:pdahiya]]

By default spocs.data state in discovery stream is set to {}. In loadSpocs, if a spoc end point fail to fetch, spocs is returned empty object and returns spocs.data as undefined

https://github.com/mozilla/activity-stream/blob/master/lib/DiscoveryStreamFeed.jsm#L391

See https://github.com/mozilla/activity-stream/pull/4928#discussion_r280122719

Steps to replicate issue:

1. Set this pref browser.newtabpage.activity-stream.discoverystream.endpoints to https,http
2. In the browser, set this pref browser.newtabpage.activity-stream.discoverystream.config to {"api_key_pref":"extensions.pocket.oAuthConsumerKey","collapsible":true,"enabled":true,"show_spocs":true,"hardcoded_layout":false,"personalized":false,"layout_endpoint":"https://gist.githubusercontent.com/punamdahiya/527dcd96584f1ae7d932b19771b18ef0/raw/5ab7fc646895b6f11cfb1ccaba4d9fd04853fceb/spoc-url-fail.json"}

Actual
Spoc end point fetch fails with spocs.data undefined error message in console
and pocket stories not loaded

Expected

Pocket stories should load without spocs

Comment 1

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/5c4931404035

Comment 2

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (68.0a1 Build ID - 20190506214617) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3. Now, the "Pocket" stories are loaded without spocs.