Closed Bug 1548971 Opened 5 years ago Closed 2 years ago

Windows crash report line number is not the best in specific crash report

Categories

(Toolkit :: Crash Reporting, defect, P3)

defect

Tracking

()

RESOLVED FIXED

People

(Reporter: kats, Unassigned)

References

(Blocks 1 open bug)

Details

Here's a crash in webrender on Windows: https://crash-stats.mozilla.com/report/index/406f7e58-f097-4cc6-9f2e-75acb0190503 - the most useful stack frame is #5 but it points to line 3034 in the source which is start of the lambda that contains the actual source of the panic. This is not super helpful.

By contrast here is the equivalent Linux crash: https://crash-stats.mozilla.com/report/index/de259650-88ec-4c51-885e-cc2020190503 which points to the right line number.

Note that in both cases the MOZ_CRASH Reason is correct and contains the assertion message, so that's good.

Unfortunately the Windows situation is the status-quo. The improved stacks on Linux are thanks to :froydnj's work on bug 524410 which depends on inlining information in DWARF files and thus does not affect Windows. From what I can tell Windows' PDB files should also contain information about inlined functions and we might be able to use that to produce the same results as for Linux.

Priority: -- → P3

Bug 1398533 should fix this and all similar problems by displaying the actual inlined function.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.