1549013 - armagadd-on-2.0 is CLOSING Containerized tabs

Status: RESOLVED DUPLICATE of bug 1549204

(WebExtensions :: Developer Outreach, defect, P3)

Description

[Ashish Vashisht]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/74.0.3729.108 Safari/537.36

Steps to reproduce:

1. Set date to past to allow installing Multi-Account Containers
2. Open a few tab in the non-default container.
3. Set date to current date and let Muti-Account Containers get disabled

Actual results:

All the containerized tabs will get closed and show up in the recently closed tabs list. They can be reopened with the proper container (if you detect it fast enough) from the same list (although new containerized tabs cannot be opened)

Expected results:

Tabs should not get closed. If a user has a LOT of containerized tabs (specially along with Tree Style Tab) this will seriously mess things up for them even after the add-on bug is fixed as the tree structure will be gone.

Comment 1

[Elle Solomina (she/her)]

I confirmed that. This is pizdec.

Currently I use crutch to temporary disable verification for already installed addons:

// Re-enable all extensions
// You need to set
// devtools.chrome.enabled
// to true

async function set_addons_as_signed() {
    Components.utils.import("resource://gre/modules/addons/XPIDatabase.jsm");
    Components.utils.import("resource://gre/modules/AddonManager.jsm");
    let addons = await XPIDatabase.getAddonList(a => true);

    for (let addon of addons) {
        // The add-on might have vanished, we'll catch that on the next startup
        if (!addon._sourceBundle.exists())
            continue;

        if( addon.signedState != AddonManager.SIGNEDSTATE_UNKNOWN )
            continue;

        addon.signedState = AddonManager.SIGNEDSTATE_NOT_REQUIRED;
        AddonManagerPrivate.callAddonListeners("onPropertyChanged",
                                                addon.wrapper,
                                                ["signedState"]);

        await XPIDatabase.updateAddonDisabledState(addon);

    }
    XPIDatabase.saveChanges();
}

set_addons_as_signed();

Comment 2

[Elle Solomina (she/her)]

P.S. open about:addons, press F12, and past this code into console.

Comment 3

[Aiden Gregg]

I am also having this problem. After having my add-ons disabled, all of my container tabs were closed, and all of my containers themselves were deleted and replaced with the default Personal/Work/Banking/Shopping containers.

Comment 4

[Umair Ahmed]

All my tabs got closed (more than 30 container tabs) when the clock hit the time required for the cert to invalidate itself. I have effectively lost the way now as most of them were opened quite a while ago, thus, leaving me with no way to track back to that state again.

Comment 5

[Martin Staffa]

I can confirm what Aiden Gregg has said. All my custom containers are lost after the hotfix for the addon bug, and also still gone after the bug fix release. I assume they are gone for good. It's quite baffling how this could even happen and I hope it gets investigated so it doesn't happen again.

Comment 6

[Dão Gottwald [:dao]]

(In reply to Umair Ahmed from comment #4)

All my tabs got closed (more than 30 container tabs) when the clock hit the time required for the cert to invalidate itself. I have effectively lost the way now as most of them were opened quite a while ago, thus, leaving me with no way to track back to that state again.

Check the sessionstore-backups folder in your profile directory (which you can find from about:profiles) -- your old data might still be there. It might be too late already if you restarted Firefox multiple times, but worth checking.

Comment 7

[Umair Ahmed]

(In reply to Dão Gottwald [::dao] from comment #6)

(In reply to Umair Ahmed from comment #4)

All my tabs got closed (more than 30 container tabs) when the clock hit the time required for the cert to invalidate itself. I have effectively lost the way now as most of them were opened quite a while ago, thus, leaving me with no way to track back to that state again.

Check the sessionstore-backups folder in your profile directory (which you can find from about:profiles) -- your old data might still be there. It might be too late already if you restarted Firefox multiple times, but worth checking.

I didn't lose the container settings, as its happening with many users. They came back once I installed the study manually.

Comment 8

[Caitlin Neiman [:caitmuenster]]

I see that Tanvi and Luke have already been needinfo'd; Jonathan, I also wanted to put this on your radar.

Comment 9

[Jonathan Kingston [:jkt] he/him]

I think this is a duplicate of Bug 1549204 where there is active discussion on how we should approach fixing this issue. I don't think there is any mitigations we can do other than those discussed there.

Thanks for raising.

Comment 10

[Tanvi Vyas[:tanvi]]

Removing my needinfo here since bug 1549204 is filed to handle this.

Comment 11

[Luke Crouch [:groovecoder]]

clearing ni