154904 - unable to drag & drop links from sidebar into browser window

Status: VERIFIED FIXED

(Camino Graveyard :: General, defect)

Description

[sairuh (rarely reading bugmail)]

should we be able to drag and drop links between the sidebar (bookmarks tab) and
the browser window? so far i cannot, using 2002.06.27.05 bits.

1. have sidebar opened.
2. drag a link from the bookmarks tab into the browser window.

result: nothing happens, not even animation.

1. have sidebar opened.
2. drag a link from the browser window into the bookmarks tab of the sidebar.

result: animation occurs, but i cannot drop the link onto any folder in the
bookmarks tab. (nothing gets added.)

Comment 1

[Chris Petersen]

This has been fixed in a newer build (2002-06-28-05) Marking WFM.

Comment 2

[sairuh (rarely reading bugmail)]

the first case of d'n'd'ing a link from the sidebar to the browser window works.
however, i cannot figure out how to get the second case to work.

perhaps i'm not dragging the link onto the right part of the Sidebar? i've tried
dropping onto a folder, near the bottom of the list, onto the tab itself in the
sidebar...what is the exact "active" spot for dropping in the sidebar?

(tested using 2002.07.01.05 nb)

Comment 3

[Chris Petersen]

Oops. I misread your second case as dragging a URL address (from the URL field)
in the sidebar. Your correct, dragging a page link to the sidebar isn't working.
I believe there is a related bug about that issue, but can't remember which bug
# it is.

Comment 4

[sairuh (rarely reading bugmail)]

would that be bug 149514?

Comment 5

[sairuh (rarely reading bugmail)]

reopening and clarifying summary for the remaining issue.

however, pls dup if there's an existing bug on that (i couldn't quite find one).

Comment 6

[saari (gone)]

->pinkerton

Comment 7

[saari (gone)]

changing summary to what I see now... can't drag links from sidebar into browser
window. Going from window to sidebar works

Comment 8

[Simon Fraser [no longer active]]

Mine.

Comment 9

[Simon Fraser [no longer active]]

Fix;

Index: BookmarksDataSource.mm
===================================================================
RCS file: /cvsroot/mozilla/chimera/BookmarksDataSource.mm,v
retrieving revision 1.5
diff -u -r1.5 BookmarksDataSource.mm
--- BookmarksDataSource.mm      10 Jul 2002 21:53:24 -0000      1.5
+++ BookmarksDataSource.mm      19 Jul 2002 01:42:43 -0000
@@ -807,7 +807,7 @@
   nsCOMPtr<nsIContent> item = [self contentNode];
   nsCOMPtr<nsIDOMElement> element(do_QueryInterface(item));
   nsAutoString href;
-  element->GetAttribute(NS_LITERAL_STRING("name"), href);
+  element->GetAttribute(NS_LITERAL_STRING("href"), href);
   return [NSString stringWithCharacters: href.get() length: href.Length()];
 }

checked in.

Comment 10

[Simon Fraser [no longer active]]

*** Bug 156254 has been marked as a duplicate of this bug. ***

Comment 11

[Chris Petersen]

Cool, this is now functional in today's build (2002-07-19-05).

Comment 12

[Winnie Lam]

marking verified