1549041 - audible is no longer fired with tabs.onUpdated after a tab is reloaded or a navigation happened

Status: VERIFIED FIXED

(Core :: Web Audio, defect, P2)

Description

[stoically]

Steps to reproduce:

With WebExtension

• Register tabs.onUpdated listener
• Navigate to a website that plays sound, e.g. soundcloud.com/discover and click any playlist
• tabs.onUpdated fires with audible changeInfo
• Reload the page
• Start playlist again
• tabs.onUpdated doesn't fire with audible changeInfo

Without WebExtension

• Open new tab
• Navigate to a website that plays sound, e.g. soundcloud.com/discover and click any playlist
• See the loudspeaker appear in the tab bar
• Reload the page
• Start playlist again
• See no loudspeaker appear in the tab bar

Expected behavior:

tabs.onUpdated with audible changeInfo should always fire and the loudspeaker should always appear if there's sound in a tab.

Actual behavior:

tabs.onUpdated doesn't fire with audible changeInfo and the loudspeaker doesn't appear after reloading the page if there's audio in the tab.

Notes

Not sure if this is actually a WebExtension bug, since the loudspeaker is also affected.

Tested with Firefox Dev Edition 67.0b15 and Nightly 68.0a1 (2019-05-03) on Linux. And with Nightly 68.0a1 (2019-04-02) on Windows 10.

Works as expected in Firefox 66.0.3.

Comment 1

[Alice0775 White]

I can reproduce the issue on Nightly68.0a1 windows10.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=4bca50b46b48d008ecf6ef19200963056d49d222&tochange=3a9d2f91b02203fc9e538fcfe51e2cb5cf620b29

Regressed by: 3a9d2f91b02203fc9e538fcfe51e2cb5cf620b29 Paul Adenot — Bug 1528319 - Don't create a Promise when shutting down an AudioContext. r=karlt

Paul Adenot (:padenot),
Your patch seems to cause the regression. Can you please look into this?

Comment 2

[Pascal Chevrel:pascalc]

P2, fix-optional for a 67 dot release as a ride along

Comment 3

[Paul Adenot (:padenot)]

Attachment: Bug 1549041 - Destroy the AudioChannelAgent in CloseInternal instead of Close. r?karlt

Comment 4

[Paul Adenot (:padenot)]

Attachment: Bug 1549041 - Test that documents receive the right audio notification events when playback is done using the Web Audio API. r?karlt

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/baa019d214ce
Destroy the AudioChannelAgent in CloseInternal instead of Close. r=karlt
https://hg.mozilla.org/integration/autoland/rev/6d0bd72a5967
Test that documents receive the right audio notification events when playback is done using the Web Audio API. r=karlt

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/baa019d214ce
https://hg.mozilla.org/mozilla-central/rev/6d0bd72a5967

Comment 7

[Oana Botisan, Desktop QA]

I managed to reproduce the issue using an older version of Nightly (2019-05-07) on Windows 10 x64.
I retested everything using latest Nightly 69.0a1 and Firefox 68.0b12 on Windows 10 x64, macOS 10.13 and Ubuntu 18.04 x64 and the bug is not reproducing anymore.