1549122 - Prevent deadlock when search extensions upgraded on startup

Status: RESOLVED FIXED

(Firefox :: Search, defect, P1)

Description

[Dale Harvey (:daleharvey)]

https://bugzilla.mozilla.org/show_bug.cgi?id=1549075#c12 explains a deadlock that could be hit if search extensions were upgraded on startup, that bug is being fixed in a different way so this will no longer get hit, but we should prevent against it

Comment 1

[Shane Caraveo (:mixedpuppy)]

I'm going to argue that this is a P1 since there is a potential for a deadlock if updates happen on startup, and if that happens we're all kinds of broke.

Comment 2

[Dale Harvey (:daleharvey)]

Attachment: Bug 1549122 - Duct tape to prevent deadlock when search extensions upgraded on startup.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/a40e9f3da7ac
Duct tape to prevent deadlock when search extensions upgraded on startup. r=mikedeboer a=Aryx

Comment 4

[Rob Wu [:robwu]]

I'm looking for a permanent fix.

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

Assuming other branches are affected; please change the flag if that's not correct.

Comment 6

[:Gijs (he/him)]

My understanding is this bustage relates to the new search-engines-as-addons code, so 66 and 67 are unaffected. Mike (or someone else on the search team), can you confirm and if so update the release flags accordingly? Thanks.

Comment 7

[:Gijs (he/him)]

Hey look, a mid-air.

Comment 9

[Shane Caraveo (:mixedpuppy)]

reassigning to dale since a patch has landed on this. I'll create a new bug for overall refactoring of the search extension loading.

Comment 10

[Dale Harvey (:daleharvey)]

Shanes refactor will likely fix this in a more elegant way on the addon side but will limit this bug for tracking the quick fix