Closed Bug 1549273 Opened 6 years ago Closed 6 years ago

Green up talos-perf-reftest-singletons (talos-ps) on Windows 10 aarch64

Categories

(Testing :: Performance, defect, P2)

Version 3
defect

Tracking

(firefox71 fixed)

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: stephend, Assigned: stephend)

References

Details

Attachments

(1 file)

Green up talos-perf-reftest-singletons (https://searchfox.org/mozilla-central/rev/b2015fdd464f598d645342614593d4ebda922d95/taskcluster/ci/test/talos.yml#305-320) runs (currently relagated to try by the trail in bug 1547044, bug 1546595, and bug 1531876) on Windows 10 aarch64.

Bobby, I'm guessing, but not assuming, that https://wiki.mozilla.org/Performance_sheriffing/Talos/Tests#perf-reftest-singletons is out-of-date, and there's potentially a better contact to ask the following:

Given this seems stable on try, would you/team want this back on (an)other branch(es)? Thanks!

Also, I'll happily update https://wiki.mozilla.org/Performance_sheriffing/Talos/Tests#perf-reftest-singletons with the correct owner(s), once identified.

Flags: needinfo?(bobbyholley)

So that I understand - this is about bringing up that particular talos sub-suite (which currently runs on most platforms) for windows aarch64?

If so, I think we might as well turn them on, unless there's a reason not to - for consistency if nothing else. Thoughts Cameron?

Flags: needinfo?(bobbyholley) → needinfo?(cam)

(In reply to Bobby Holley (:bholley) from comment #3)

So that I understand - this is about bringing up that particular talos sub-suite (which currently runs on most platforms) for windows aarch64?

<snip>
Yes, and sorry for the delay in responding (PTO + paternity); new try push here: https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=b1f7e3ac51373041f23bf7c5a05ae8706350c295

If these tests are running, and they're not abnormally noisy or anything, then I don't see any reason not to turn them on. If the tests are broken for some reason, I would want to check on our ARM64 priorities before looking into that.

Flags: needinfo?(cam)

(In reply to Cameron McCormack (:heycam) from comment #5)

If these tests are running, and they're not abnormally noisy or anything, then I don't see any reason not to turn them on. If the tests are broken for some reason, I would want to check on our ARM64 priorities before looking into that.

Great, thanks; a followup question and a request, if you would?

  1. Is the information on https://wiki.mozilla.org/TestEngineering/Performance/Talos/Tests#perf-reftest-singletons up-to-date, still? i.e. if I/others need to pester someone (sorry) about this test, whom would that be? Still Bobby, or you, now, Cam?
  2. For this test, are the current mozilla-central and try branches enough coverage? (Or, am I not understanding talos.yaml quite right, and perhaps it'll also pick up trunk from the defaults section? https://searchfox.org/mozilla-central/rev/9bb55ae4d808fc48afcf93f99da6a685265b86c6/taskcluster/ci/test/talos.yml#311-322

Thanks!

Flags: needinfo?(cam)

Probably best to put my name down there.

I am honestly not familiar enough with talos.yml to know what's the right thing to put there, and I also don't know what trunk refers to. But I suggest copying one of the other configurations that looks like it doesn't have any special cases, so:

            linux64-ccov/.*: ['try']
            windows10-64-ccov/.*: ['try']
            (?:windows10-64|windows7-32|linux64)(?:-qr)?/opt: ['mozilla-central', 'try']
            windows10-aarch64/opt: ['mozilla-central', 'try']
            macosx.*64(?:-shippable)?(?:-qr)?/opt: ['mozilla-central', 'try']
            default: ['mozilla-beta', 'trunk', 'try']
Flags: needinfo?(cam)
  1. Thanks, Cam, Bobby; I've updated the wiki with Cam as the new owner/contact, dev-side: https://wiki.mozilla.org/index.php?title=TestEngineering%2FPerformance%2FTalos%2FTests&type=revision&diff=1217429&oldid=1217380
  2. re: adding in mozilla-beta to the default; I'll get a patch tested + up
  3. This looks largely stable now on windows10-aarch64: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&selectedJob=266297154&tier=1%2C2%2C3&searchStr=perf-reftest-singleton%2Caarch
Pushed by sdonner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4510ffb529a4 Green up talos-perf-reftest-singletons on windows10-aarch64; add mozilla-beta branch to defaults. r=heycam
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71

Just to leave a bit of a paper trail/breadcrumb, here, I filed and fixed up talos-perf-reftest to also have the mozilla-beta branch included in its defaults, over in bug 1581607 (thanks for the suggestion/request, Cam!)

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: