1549283 - Add missing calls to `SerializeNodeEnd` in `nsDocumentEncoder`

Status: RESOLVED FIXED

(Core :: DOM: Serializers, enhancement)

Description

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

In order to have one call of SerializeEndNode for every SerializeStartNode call. This make it simpler to reason about the program and potentially prevents future bugs.

Comment 1

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1549283: add missing calls to `SerializeNodeEnd`

In order to have one call of SerializeNodeEnd for every SerializeNodeStart
call. In the current state of the code, the absence of these calls doesn't
cause bugs, but this can change anytime SerializeNodeEnd is changed. Moreover,
it makes it simpler to reason about the code.

Comment 2

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Requesting checkin. A corresponding try run (https://treeherder.mozilla.org/#/jobs?repo=try&revision=6bb85430a44a912038cecc47e2f76c74a0a5f2ca&selectedJob=244518297) has only unrelated failures.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59306f187449
add missing calls to SerializeNodeEnd r=hsivonen

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/59306f187449