Add missing calls to `SerializeNodeEnd` in `nsDocumentEncoder`

RESOLVED FIXED in Firefox 68

Status

()

enhancement
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: mbrodesser, Assigned: mbrodesser)

Tracking

unspecified
mozilla68
Points:
---

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(1 attachment)

In order to have one call of SerializeEndNode for every SerializeStartNode call. This make it simpler to reason about the program and potentially prevents future bugs.

Assignee: nobody → mbrodesser

In order to have one call of SerializeNodeEnd for every SerializeNodeStart
call. In the current state of the code, the absence of these calls doesn't
cause bugs, but this can change anytime SerializeNodeEnd is changed. Moreover,
it makes it simpler to reason about the code.

Keywords: checkin-needed

Pushed by dluca@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/59306f187449
add missing calls to SerializeNodeEnd r=hsivonen

Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.