1549326 - Remove simpletest.js from eval()-whitelist

Status: RESOLVED FIXED

(Core :: DOM: Security, enhancement, P3)

Description

[Jonas Allmann [:jallmann]]

Simpletest.js triggers the eval-assertion from Bug 1473549 in some tests.
The file itself does not contain eval() or new Function. Some occurences of setTimeout() might end up being called with string literals, but this doesn't seem to be the case either.

In all cases examined so far, test files call functions from simpletest.js through setTimeout() with string literals, causing the assertion to be triggered with simpletest.js showing up as the cause.

These test files have to be found and refactored to avoid using setTimeout() with string literals.

Comment 1

[Jonas Allmann [:jallmann]]

Attachment: Bug 1549326 - Remove simpletest.js from eval()-whitelist, r=ckerschb

Amend several test files for triggering eval() assertion through simpletest.js

Comment 2

[Noemi Erli[:noemi_erli]]

Received the following while trying to land this:
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. (255, 'applying /tmp/tmps9UlqT\npatching file modules/libpref/init/all.js\nHunk #1 FAILED at 2660\n1 out of 1 hunks FAILED -- saving rejects to file modules/libpref/init/all.js.rej\nabort: patch failed to apply', '')

Comment 3

[Jonas Allmann [:jallmann]]

Rebased patch.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e925cef1cadf
Remove simpletest.js from eval()-whitelist, r=ckerschb

Comment 5

[Cristian Brindusan [:cbrindusan]]

Backed out changeset e925cef1cadf (Bug 1549326) for mochitest assertion failures at nsContentSecurityManager.cpp:205.

Backout: https://hg.mozilla.org/integration/autoland/rev/cefcbfd25b82fedbbb010b9499f6334c89bdf18c

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=e925cef1cadfa7dc2dff699ae3d980a11705196c&selectedJob=245586246

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=245586246&repo=autoland&lineNumber=9788

Comment 6

[Jonas Allmann [:jallmann]]

Fixed all remaining test failures.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=73f1e6f1e564a1cc9fc01ebf3891e7d57f6197d3

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/39446af6b4ad
Remove simpletest.js from eval()-whitelist, r=ckerschb

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/39446af6b4ad