Remove simpletest.js from eval()-whitelist

RESOLVED FIXED in Firefox 68

Status

()

enhancement
P3
normal
RESOLVED FIXED
Last month
Last month

People

(Reporter: jallmann, Assigned: jallmann)

Tracking

(Blocks 1 bug)

unspecified
mozilla68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox68 fixed)

Details

(Whiteboard: [domsecurity-backlog1])

Attachments

(1 attachment)

Assignee

Description

Last month

Simpletest.js triggers the eval-assertion from Bug 1473549 in some tests.
The file itself does not contain eval() or new Function. Some occurences of setTimeout() might end up being called with string literals, but this doesn't seem to be the case either.

In all cases examined so far, test files call functions from simpletest.js through setTimeout() with string literals, causing the assertion to be triggered with simpletest.js showing up as the cause.

These test files have to be found and refactored to avoid using setTimeout() with string literals.

Assignee

Comment 1

Last month

Amend several test files for triggering eval() assertion through simpletest.js

Assignee

Updated

Last month
Keywords: checkin-needed

Received the following while trying to land this:
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. (255, 'applying /tmp/tmps9UlqT\npatching file modules/libpref/init/all.js\nHunk #1 FAILED at 2660\n1 out of 1 hunks FAILED -- saving rejects to file modules/libpref/init/all.js.rej\nabort: patch failed to apply', '')

Flags: needinfo?(jallmann)
Assignee

Comment 3

Last month

Rebased patch.

Flags: needinfo?(jallmann)

Comment 4

Last month

Pushed by nerli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e925cef1cadf
Remove simpletest.js from eval()-whitelist, r=ckerschb

Keywords: checkin-needed
Assignee

Comment 6

Last month
Flags: needinfo?(jallmann)
Keywords: checkin-needed

Comment 7

Last month

Pushed by ncsoregi@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/39446af6b4ad
Remove simpletest.js from eval()-whitelist, r=ckerschb

Keywords: checkin-needed

Comment 8

Last month
bugherder
Status: ASSIGNED → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.