1549373 - Mozilla Firefox Nightly 68.0a1 (2019-05-06) crashes in [@ mozilla::dom::BrowsingContext::Detach ]

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect, P1)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

STR:

1. Open this website page https://imgur.com/
2. Open some image
3. Press back browser button
   and enjoy crash in [@ mozilla::dom::BrowsingContext::Detach ]
   https://crash-stats.mozilla.org/report/index/d63be416-91cf-48b1-9ca0-4cc230190506

Same STR like from bug #1547911, so I suspect it's not fixed completely and regression range is same.

Comment 1

[Andreas Farre [:farre]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f04e547fe7fd6165a6e3b4b7d13c55d4a67f8bb9

Comment 2

[Andreas Farre [:farre]]

Attachment: Bug 1549373 - Make BrowsingContexts stay alive long enough to be detached. r=nika

Comment 3

[Andreas Farre [:farre]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=af18621b4612aee004f843a8ba93da62fa935cc2

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d8bdc083e77
Make BrowsingContexts stay alive long enough to be detached. r=nika

Comment 5

[Mark]

My steps to reproduce the tab crashes as of Build-ID: 20190506130308 for Nightly (64-bit) on Windows 10 (64-bit):

1. Create a brand new profile in Nightly.

2. Launch Nightly using that new profile.

3. Add extension: either uBlock Origin or AdBlock Plus

4. Shut down that Nightly.

5. Launch Nightly using that same (new) profile.

6. Navigate to https://imgur.com/

7. Click on an image to go into a story. (Can be video or still picture)

8. Click on the Back button by the URL bar.

• Note: TAB CRASHED

This does not happen if in step 3 I had added IPvFoo instead of an ad blocker.

I don't know what makes imgur.com special since I can use an ad blocker and on many sites drill down and later click on the Back button without any crashes.

Comment 6

[Andreas Farre [:farre]]

Thanks for the updated STR! I can confirm that patch in Comment 4 fixes this.

Comment 7

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/2d8bdc083e77

Comment 8

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

I'm confirming that bug is fixed, no more crashes in Mozilla Firefox Nightly 68.0a1 (2019-05-07) looking at Reports, so I'm marking this bug as VERIFIED.
Thank you very much! \o/

Comment 9

[Chris Peterson [:cpeterson]]

Retroactively moving fixed bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to an appropriate Fission Milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Comment 10

[Firefox Bug Husbandry Bot]

Please specify a root cause for this bug. See :tmaity for more information.

Comment 11

[Andreas Farre [:farre]]

Description of root cause:

Race between parent having closed a browsing context that a child wanted to detach from a tree. Possible sub-category for Coding could be Parallelism issue (similar to concurrency, but not the same since handling cross process errors