Closed Bug 1549516 Opened 6 years ago Closed 1 year ago

[meta] Page.javascriptDialogOpening

Categories

(Remote Protocol :: CDP, task)

Product:
Remote Protocol
Component:
CDP
Type:
task

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: ato, Unassigned)

References

(
URL
)

Details

(Keywords: meta, Whiteboard: [event=Page.javascriptDialogOpening])

No description provided.
Blocks: puppeteer
URL: https://chromedevtools.github.io/devt...
Keywords: meta
Whiteboard: [event=Page.javascriptDialogOpening]

The basic implementation was done on bug 1545724. It misses the following properties on the returned object:

  • url
  • hasBrowserHandler
  • defaultPrompt

To create a Dialog instance Puppeteer also uses defaultPrompt as argument of the constructor, which defaults to an empty string.

Gutenberg doesn't use it and as such it isn't a blocker for the alpha release.

Depends on: 1545724

A relevant error from Puppeteer unit test (test/dialog.spec.js) logs:

remote/content/domains/parent/page/DialogHandler.jsm, line 103: TypeError: this._browser.tabModalPromptBox is undefined (Page.javascriptDialogOpening)

Maja, mind filing this as a new bug blocking this one? As best also with a link to the log, or the log attached.

Flags: needinfo?(mjzffr)
Component: CDP: Page → CDP
Severity: normal → S3

All what we could do for this API is done.

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.