Closed Bug 1549548 Opened 6 months ago Closed 5 months ago

Update browser_ tests for plugin blocking in browser/base/content/ and toolkit/mozapps/extensions/test/browser to work with the non-xml remote settings implementation of the blocklist

Categories

(Toolkit :: Blocklist Implementation, task, P1)

task

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox68 --- fixed
firefox69 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

Details

Attachments

(1 file)

In bug 1257565 I'll make them forcibly use the XML version. For the future, we need to make sure the tests work with the remote settings version.

Summary: Update browser_ tests for plugin blocking in browser/base/content/ to work with the non-xml remote settings implementation of the blocklist → Update browser_ tests for plugin blocking in browser/base/content/ and toolkit/mozapps/extensions/test/browser to work with the non-xml remote settings implementation of the blocklist
Type: defect → task
Priority: -- → P1

Note to self: bug 1129040 removed the users of plugin_clickToPlayAllow.html and -Deny.html, but left the files.

Ditto browser/base/content/test/plugins/plugin_test3.html

Annnnd bug 1307445 removed the only consumer of dom/base/test/chrome/blockNoPlugins.xml without removing that.

Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/6d0bd1cdd4be
update browser tests for plugin blocking, r=mconley
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69

Comment on attachment 9065228 [details]
Bug 1549548 - update browser tests for plugin blocking, r?mconley

Beta/Release Uplift Approval Request

  • User impact if declined: Missing test coverage on plugins and the remote settings blocklist on 68.

Note: please also consider this a request for the esr68 branch as well, for which it seems there is no bmo flag yet.

  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: n/a
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Automated tests only.
  • String changes made/needed: nope
Attachment #9065228 - Flags: approval-mozilla-beta?

Ritu, I don't see an esr68 approval flag, so needinfo'ing you just in case. :-)

Flags: needinfo?(rkothari)

Thanks Gijs! Hey Jcristau, are beta uplifts automatically uplifted to esr68? Just want to make sure this fix doesn't miss uplift to ESR68.

Flags: needinfo?(rkothari) → needinfo?(jcristau)

I believe beta will be merged to esr68 at least up until the July 1 merge day.

Flags: needinfo?(jcristau)

Comment on attachment 9065228 [details]
Bug 1549548 - update browser tests for plugin blocking, r?mconley

this is test-only so doesn't require release mgmt approval

Attachment #9065228 - Flags: approval-mozilla-beta?
Whiteboard: [checkin-needed-beta]
Whiteboard: [checkin-needed-beta]
You need to log in before you can comment on or make changes to this bug.