1549548 - Update browser_ tests for plugin blocking in browser/base/content/ and toolkit/mozapps/extensions/test/browser to work with the non-xml remote settings implementation of the blocklist

Status: RESOLVED FIXED

(Toolkit :: Blocklist Implementation, task, P1)

Description

[:Gijs (he/him)]

In bug 1257565 I'll make them forcibly use the XML version. For the future, we need to make sure the tests work with the remote settings version.

Comment 1

[:Gijs (he/him)]

Note to self: bug 1129040 removed the users of plugin_clickToPlayAllow.html and -Deny.html, but left the files.

Comment 2

[:Gijs (he/him)]

Ditto browser/base/content/test/plugins/plugin_test3.html

Comment 3

[:Gijs (he/him)]

Annnnd bug 1307445 removed the only consumer of dom/base/test/chrome/blockNoPlugins.xml without removing that.

Comment 4

[:Gijs (he/him)]

Try looks OK though somehow macOS tests are slow to run:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=841a34729dfcfae1f2f418d81c3e4f2f3f5d3db4

Comment 5

[:Gijs (he/him)]

Attachment: Bug 1549548 - update browser tests for plugin blocking, r?mconley

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d0bd1cdd4be
update browser tests for plugin blocking, r=mconley

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/6d0bd1cdd4be

Comment 8

[:Gijs (he/him)]

Comment on attachment 9065228 [details]
Bug 1549548 - update browser tests for plugin blocking, r?mconley

Beta/Release Uplift Approval Request

• User impact if declined: Missing test coverage on plugins and the remote settings blocklist on 68.

Note: please also consider this a request for the esr68 branch as well, for which it seems there is no bmo flag yet.

• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: n/a
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Automated tests only.
• String changes made/needed: nope

Comment 9

[:Gijs (he/him)]

Ritu, I don't see an esr68 approval flag, so needinfo'ing you just in case. :-)

Comment 10

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Thanks Gijs! Hey Jcristau, are beta uplifts automatically uplifted to esr68? Just want to make sure this fix doesn't miss uplift to ESR68.

Comment 11

[Julien Cristau [:jcristau]]

I believe beta will be merged to esr68 at least up until the July 1 merge day.

Comment 12

[Julien Cristau [:jcristau]]

Comment on attachment 9065228 [details]
Bug 1549548 - update browser tests for plugin blocking, r?mconley

this is test-only so doesn't require release mgmt approval

Comment 13

[Razvan Maries]

https://hg.mozilla.org/releases/mozilla-beta/rev/7619b650e72a