1549595 - Three inbuilt themes are disabled

Status: RESOLVED WORKSFORME

(Toolkit :: Add-ons Manager, defect)

Description

[Gabriela [:gaby2300]]

Attachment: Three disabled themes.png

Windows 7 64 bit. Nightly version 68.0a1
Build ID 20190506130308

I have the 3 inbuilt themes disabled: Default, Dark and Light. The actual one is the Dark one which I dislike but I cannot change it.

No chance to toggle them: All are grey. I mean, in the Themes panel I see Dark, for example and Disabled between brackets so I see: Dark (Disabled). And the same for Default and Light.

about:studies shows both hot fixes complete.

STR

1 Open Nightly
2 Open the Addons Manager
3 See the Theme Panel
4 Notice all 3 themes are disabled and grey
5 No chance to select anyone

Expected: I should be able to select between the 3 themes
Actual: all 3 themes are disabled and grey, no chance to select anyone

Adding screenshot

Comment 1

[:Gijs (he/him)]

Are there errors in the browser console on startup?

Can you attach a copy of the raw data from about:support from your profile?

Comment 2

[Gabriela [:gaby2300]]

(In reply to :Gijs (he/him) from comment #1)

Are there errors in the browser console on startup?
I don't know how to look for them. Will do if you tell me how to proceed

Can you attach a copy of the raw data from about:support from your profile?

I can, it's very long though. I will paste it here if you don't mind the noise. Or maybe you can suggest me a way to create a link with it instead?

Comment 3

[Andrew Swan [:aswan]]

(In reply to Gabriela [:gaby2300] from comment #2)

Can you attach a copy of the raw data from about:support from your profile?

I can, it's very long though. I will paste it here if you don't mind the noise. Or maybe you can suggest me a way to create a link with it instead?

You can use "attach file" on this page

Comment 4

[Andrew Swan [:aswan]]

(In reply to Gabriela [:gaby2300] from comment #2)

Are there errors in the browser console on startup?
I don't know how to look for them. Will do if you tell me how to proceed

Ah, and for this:
https://developer.mozilla.org/en-US/docs/Tools/Browser_Console

Comment 5

[Gabriela [:gaby2300]]

Attachment: The profile raw data

Comment 6

[Gabriela [:gaby2300]]

I can see the following in the browser console at start up:

Content Security Policy: Ignorando "'unsafe-inline'" dentro de script-src o style-src: se especificó nonce-source o hash-source

Ignoring = Ignorando; dentro = in/inside; se especificó = was specified

La solicitud de acceso a las cookies o al almacenamiento en “https://secure.gravatar.com/avatar/155ca87260cf2057a5f694d394294b91?d=mm&size=64” fue bloqueado porque provino de un rastreador y está habilitado el Bloqueo de contenido. show_bug.cgi

La solicitud de acceso a las cookies o al almacenamiento en “https://secure.gravatar.com/avatar/66445733c06687eafa2978764675104f?d=mm&size=64” fue bloqueado porque provino de un rastreador y está habilitado el Bloqueo de contenido. show_bug.cgi

La solicitud de acceso a las cookies o al almacenamiento en “https://secure.gravatar.com/avatar/496476a2ad7f9a413659259637e917b0?d=mm&size=64” fue bloqueado porque provino de un rastreador y está habilitado el Bloqueo de contenido. show_bug.cgi

Content Security Policy: Ignorando "'unsafe-inline'" dentro de script-src o style-src: se especificó nonce-source o hash-source

La solicitud de acceso a las cookies o al almacenamiento en = Request to access cookies or storage in

fue bloqueado porque provino de un rastreador y está habilitado el Bloqueo de contenido. show_bug.cgi = was blocked because it came from a tracker and Block trackers is enabled

Very sorry for this but my nightly is in Spanish. I translated the Spanish words for you to understand.

Comment 7

[Andrew Swan [:aswan]]

Gracias. Yo puedo entender un poco de español pero esto nos ayuda.

I'm not sure exactly what's going on here, but to help troubleshoot further would you mind attaching a copy of extensions.json from your profile directory to this bug?

Comment 8

[Gabriela [:gaby2300]]

Attachment: extensions.json

Done!

Thank you so much for your help!

Comment 9

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Could QA see if this is fixed in M-C?

Comment 10

[Andrew Swan [:aswan]]

I think this may be another symptom of the underlying flaw that was bug 1549075. Specifically, trying to load the manifest for builtin addons (which includes builtin search engines and builtin themes) was throwing an exception, which caused these addons to be labeled as incompatible. The fix is to rebuild the database again, fortunately this should happen as a consequence of the bug 1549249 patches which recently landed.

Comment 11

[Emanuel Hoogeveen [:ehoogeveen]]

FWIW, while my theme state was stuck on the default theme, I did see a Disable/Enable button on each theme which I could toggle to get them into a sane state. I don't know why the buttons would be there for me but entirely missing here, but perhaps it's a symptom of the same bug. I do use the US English Nightly (in case localization could somehow be involved).

Comment 12

[:Gijs (he/him)]

(In reply to Andrew Swan [:aswan] from comment #10)

I think this may be another symptom of the underlying flaw that was bug 1549075. Specifically, trying to load the manifest for builtin addons (which includes builtin search engines and builtin themes) was throwing an exception, which caused these addons to be labeled as incompatible. The fix is to rebuild the database again, fortunately this should happen as a consequence of the bug 1549249 patches which recently landed.

Today's nightlies should then hopefully work, is my reading of this - Gabriela, could you check on today's nightly if the problem has been resolved? Thanks for your patience as we work all this out...

Comment 13

[Alex Cornestean]

Cannot reproduce the issue under the mentioned conditions (Nightly version 68.0a1, Build ID 20190506130308 / en-US, es-ES, es-MX, es-AR, es-CL) on Windows 10 or Windows 7.

Additionally tested on the latest Nightly build, not being able to reproduce the issue in these circumstances, as well.

Comment 14

[Gabriela [:gaby2300]]

(In reply to :Gijs (he/him) from comment #12)

(In reply to Andrew Swan [:aswan] from comment #10)

Today's nightlies should then hopefully work, is my reading of this - Gabriela, could you check on today's nightly if the problem has been resolved? Thanks for your patience as we work all this out...

Today's nightly doesn't show any issues in my work's PC which has another profile.
I will check the update in my home's one with the issue later, when I get back home.

Comment 15

[Gabriela [:gaby2300]]

(In reply to :Gijs (he/him) from comment #12)

(In reply to Andrew Swan [:aswan] from comment #10)

I think this may be another symptom of the underlying flaw that was bug 1549075. Specifically, trying to load the manifest for builtin addons (which includes builtin search engines and builtin themes) was throwing an exception, which caused these addons to be labeled as incompatible. The fix is to rebuild the database again, fortunately this should happen as a consequence of the bug 1549249 patches which recently landed.

Today's nightlies should then hopefully work, is my reading of this - Gabriela, could you check on today's nightly if the problem has been resolved? Thanks for your patience as we work all this out...5

Yes! I confirm it's fixed: the three themes can be enabled/disabled again!

Many thanks for answering me and helping me so quickly!

Comment 16

[Gabriela [:gaby2300]]

(In reply to Gabriela [:gaby2300] from comment #15)

(In reply to :Gijs (he/him) from comment #12)

(In reply to Andrew Swan [:aswan] from comment #10)

I think this may be another symptom of the underlying flaw that was bug 1549075. Specifically, trying to load the manifest for builtin addons (which includes builtin search engines and builtin themes) was throwing an exception, which caused these addons to be labeled as incompatible. The fix is to rebuild the database again, fortunately this should happen as a consequence of the bug 1549249 patches which recently landed.

Today's nightlies should then hopefully work, is my reading of this - Gabriela, could you check on today's nightly if the problem has been resolved? Thanks for your patience as we work all this out...5

Yes! I confirm it's fixed: the three themes can be enabled/disabled again in the profile with the issue.

Many thanks for answering me and helping me so quickly!

Comment 17

[:Gijs (he/him)]

Fab, thank you for confirming!

Comment 18

[Bogdan Maris, Desktop QA]

Removing qe-verify? since this was already verified by the reporter and we did not encounter this behavior during our testing on all Fx builds.