1549620 - [css-grid] repeat(auto-fill/fit) needs to take box-sizing:border-box into account for the input sizes

Status: RESOLVED FIXED

(Core :: Layout: Grid, defect, P4)

Description

[Oriol Brufau [:Oriol]]

Attachment: testcase.htm

Open attached testcase.
The columns are sized with repeat(auto-fill, 100px).
The spec says https://drafts.csswg.org/css-grid/#auto-repeat

if the grid container has a definite min size in the relevant axis, the number of repetitions is the smallest possible positive integer that fulfills that minimum requirement.

The min size is 210px, but note box-sizing: border-box; padding: 5px. Then,

• With 1 repetition, the outer size would be 5px + 1*100px + 5px = 110px, which doesn't fulfill the minimum
• With 2 repetitions, the outer size would be 5px + 2*100px + 5px = 210px, which does fulfill the minimum.

So there should be 2 columns, but there are 3.
The other axis behaves as expected, and there are 2 rows.

Note that in Chromium there are 3 columns and 3 rows, but this is being addressed in http://crrev/c/1588388

Comment 1

[Mats Palmgren (inactive)]

There are some WPTs for this, but they depend on having a working offsetLeft/offsetTop (bug 400258)...

Comment 2

[Mats Palmgren (inactive)]

Attachment: Bug 1549620 - [css-grid] Take box-sizing:border-box into account when calculating the input sizes for repeat(auto-fill/fit) track count. r=dholbert

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/18126d4319d7
[css-grid] Take box-sizing:border-box into account when calculating the input sizes for repeat(auto-fill/fit) track count.  r=dholbert

Comment 4

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/19056 for changes under testing/web-platform/tests

Comment 5

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/18126d4319d7

Comment 7

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot