1549636 - uuid1() is broken sometimes

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, defect)

Description

[Manish Goregaokar [:manishearth]]

Servo (which uses the mach package on PyPi) is getting some python asserts on CI:

https://tools.taskcluster.net/groups/TpBi32d9SvijiI4KCidF1Q/tasks/O3NH33wXQw2DxQAqLOz20A/runs/0/logs/public%2Flogs%2Flive.log#L199

  File "./mach", line 96, in <module>
    main(sys.argv)
  File "./mach", line 26, in main
    mach = mach_bootstrap.bootstrap(topdir)
  File "/Users/worker/tasks/task_1557159803/repo/python/mach_bootstrap.py", line 296, in bootstrap
    mach.load_commands_from_file(os.path.join(topdir, path))
  File "/Users/worker/tasks/task_1557159803/repo/python/_virtualenv/lib/python2.7/site-packages/mach/main.py", line 263, in load_commands_from_file
    module_name = 'mach.commands.%s' % uuid.uuid1().get_hex()
  File "/Users/worker/homebrew/Cellar/python@2/2.7.15_1/Frameworks/Python.framework/Versions/2.7/lib/python2.7/uuid.py", line 588, in uuid1
    clock_seq_hi_variant, clock_seq_low, node), version=1)
  File "/Users/worker/homebrew/Cellar/python@2/2.7.15_1/Frameworks/Python.framework/Versions/2.7/lib/python2.7/uuid.py", line 164, in __init__
    raise ValueError('field 6 out of range (need a 48-bit value)')

Poking around it seems like uuid1() uses mac addresses and is somewhat flaky. We should be using uuid4().

Comment 1

[Manish Goregaokar [:manishearth]]

Attachment: Bug 1549636: use uuid4() in mach;

Comment 2

[Manish Goregaokar [:manishearth]]

I picked uuid4 since that's what others seem to be using here.

Comment 3

[Manish Goregaokar [:manishearth]]

Try push with some random tasks picked: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3de5c73312cf395deee862930bbb74d8be92991f

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7aee5a30dd15
use uuid4() in mach; r=glandium

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/7aee5a30dd15