Closed
Bug 1549636
Opened 2 years ago
Closed 2 years ago
uuid1() is broken sometimes
Categories
(Firefox Build System :: Mach Core, defect)
Firefox Build System
Mach Core
Tracking
(firefox68 fixed)
RESOLVED
FIXED
mozilla68
Tracking | Status | |
---|---|---|
firefox68 | --- | fixed |
People
(Reporter: manishearth, Assigned: manishearth)
Details
Attachments
(1 file)
Servo (which uses the mach package on PyPi) is getting some python asserts on CI:
File "./mach", line 96, in <module>
main(sys.argv)
File "./mach", line 26, in main
mach = mach_bootstrap.bootstrap(topdir)
File "/Users/worker/tasks/task_1557159803/repo/python/mach_bootstrap.py", line 296, in bootstrap
mach.load_commands_from_file(os.path.join(topdir, path))
File "/Users/worker/tasks/task_1557159803/repo/python/_virtualenv/lib/python2.7/site-packages/mach/main.py", line 263, in load_commands_from_file
module_name = 'mach.commands.%s' % uuid.uuid1().get_hex()
File "/Users/worker/homebrew/Cellar/python@2/2.7.15_1/Frameworks/Python.framework/Versions/2.7/lib/python2.7/uuid.py", line 588, in uuid1
clock_seq_hi_variant, clock_seq_low, node), version=1)
File "/Users/worker/homebrew/Cellar/python@2/2.7.15_1/Frameworks/Python.framework/Versions/2.7/lib/python2.7/uuid.py", line 164, in __init__
raise ValueError('field 6 out of range (need a 48-bit value)')
Poking around it seems like uuid1() uses mac addresses and is somewhat flaky. We should be using uuid4().
Assignee | ||
Comment 1•2 years ago
|
||
Assignee | ||
Comment 2•2 years ago
|
||
I picked uuid4 since that's what others seem to be using here.
Assignee | ||
Comment 3•2 years ago
|
||
Try push with some random tasks picked: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3de5c73312cf395deee862930bbb74d8be92991f
Pushed by mgoregaokar@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7aee5a30dd15 use uuid4() in mach; r=glandium
Comment 5•2 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Assignee: nobody → manishearth
You need to log in
before you can comment on or make changes to this bug.
Description
•