1549723 - Enable the startup mainthread IO mochitests on debug builds

Status: NEW

(Core :: Performance, task, P3)

Description

[Florian Quèze [:florian]]

Until bug 1529125 lands, we can't enable mainthread IO startup mochitests on debug builds, but I would like to land them anyway and then them only on opt builds for now to already have some main thread I/O coverage.

Comment 1

[Florian Quèze [:florian]]

Attachment: Bug 1549723 - disable browser_startup_mainthreadio.js and browser_startup_content_mainthreadio.js mochitests for debug builds, r=mconley.

Depends on D28869

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72723e7257b1
disable browser_startup_mainthreadio.js and browser_startup_content_mainthreadio.js mochitests for debug builds, r=mconley.

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/72723e7257b1

Comment 4

[Alexandru Michis [:malexandru]]

Backed out changeset 72723e7257b1 (Bug 1549723) for causing leaks

Backout link: https://hg.mozilla.org/integration/autoland/rev/5ea2c049391367f5840bdf0f74d4e820733dae45

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&group_state=expanded&searchStr=browser-chrome&revision=72723e7257b1f9825a5f1a6478c0dbdea9202c97

Log link: https://treeherder.mozilla.org/logviewer.html#?job_id=245184064&repo=autoland

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d81d08e2b3a1
disable browser_startup_mainthreadio.js and browser_startup_content_mainthreadio.js mochitests for debug builds, r=mconley.

Comment 6

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/d81d08e2b3a1

Comment 7

[Drew Willcoxon :adw]

Florian, could you please give this bug a priority? I'll give it a P3 for now since it hasn't been commented on in a while, but please update as necessary.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:Dolske, maybe it's time to close this bug?

Comment 9

[Florian Quèze [:florian]]

This bug is still valid, unfortunately.

Comment 10

[:Gijs (he/him)]

Looks like this won't be actionable until we fix bug 1529125 though...

Comment 11

[Greg Mierzwinski [:sparky]]

Kelly, it's unclear why this was moved to Testing :: Performance. Maybe you were looking for Core :: Performance if this is a Firefox performance issue?

Comment 12

[Mike Conley (:mconley) (:⚙️)]

Hey sparky, this is related to an automated test for Firefox that tests main-thread IO, so we thought that Testing :: Performance sounded like the right fit.

Comment 13

[Greg Mierzwinski [:sparky]]

Hi :mconley, ok I think it might make more sense to have this either in the component for the suite it runs in (Testing :: Mochitest), or the component of the code in question (browser/base/content/test/). Would you know who owns these tests? Maybe they'd have a preference.

Comment 14

[Mike Conley (:mconley) (:⚙️)]

Unfortunately, browser/base/content/test doesn't have a great component. Rethinking this, let's move it to Core :: Performance, given that it was florian that was working on this.

Comment 15

[Greg Mierzwinski [:sparky]]

Perfect, thanks!