1549855 - Tidy up dead code trying to use browser.tabs.remote.force-enable in tests

Status: RESOLVED FIXED

(Firefox :: General, defect, P1)

Description

[:Gijs (he/him)]

See https://searchfox.org/mozilla-central/search?q=remote.force-enable&case=false&regexp=false&path=

bug 1548941 removes the nsAppRunner usage.

The mobile usage is dead, AFAIK, in that nothing I think ever uses e10s-based fennec, and I don't think anything much works at all if you try and enable it.

The test instances either set it at runtime (which does nothing) or use it together with browser.tabs.remote.autostart, so it has no effect.

Comment 1

[:Gijs (he/him)]

Gah, I screwed up - I don't think https://searchfox.org/mozilla-central/source/toolkit/components/extensions/test/xpcshell/head_e10s.js#6 is actually dead. I mean, it is now, but it wasn't. Assuming I'm not wrong this time, those tests are now running in non-e10s when they shouldn't be.

Comment 2

[:Gijs (he/him)]

Attachment: Bug 1549855 - actually run webextension xpcshell tests using e10s, r?zombie

Comment 3

[:Gijs (he/him)]

Attachment: Bug 1549855 - remove references to e10s force-enable pref that is no longer used, r?ato,eeejay

Depends on D31416

Comment 4

[:Gijs (he/him)]

(In reply to :Gijs (he/him) from comment #1)

Gah, I screwed up - I don't think https://searchfox.org/mozilla-central/source/toolkit/components/extensions/test/xpcshell/head_e10s.js#6 is actually dead. I mean, it is now, but it wasn't. Assuming I'm not wrong this time, those tests are now running in non-e10s when they shouldn't be.

Hopefully, this is less bad than I feared - https://phabricator.services.mozilla.com/D31416#924078 .

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9383ea5938fe
actually run webextension xpcshell tests using e10s, r=zombie
https://hg.mozilla.org/integration/autoland/rev/928038c23227
remove references to e10s force-enable pref that is no longer used, r=ato,snorp,eeejay

Comment 6

[Arthur Iakab [arthur_iakab]]

Backed out 2 changesets (bug 1549855) for failing Android mochitests on robocop_text_page.html CLOSED TREE

Backout revision https://hg.mozilla.org/integration/autoland/rev/440aa7a30693d06e6aef4bc256edc226f407ef49

Failed push https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=robocop&revision=928038c23227504c1cd7dff5f5e214501bb4b688

Failure logs https://treeherder.mozilla.org/logviewer.html#?job_id=246898464&repo=autoland
https://treeherder.mozilla.org/logviewer.html#?job_id=246898384&repo=autoland
https://treeherder.mozilla.org/logviewer.html#?job_id=246859987&repo=autoland

Gijs can you please take a look?

Comment 7

[:Gijs (he/him)]

(In reply to Arthur Iakab [arthur_iakab] from comment #6)

Backed out 2 changesets (bug 1549855) for failing Android mochitests on robocop_text_page.html CLOSED TREE

Ugh. I moved the android stuff to bug 1552442. I'm not sure if it's worth investing in it at this point; perhaps the force-enable pref can stay the way it is and only have an effect on android, or something like that (it's already not in all.js so it won't show up in about:config).

I'll reland with all the other changes.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/83894232a6bd
actually run webextension xpcshell tests using e10s, r=zombie
https://hg.mozilla.org/integration/autoland/rev/139abe6b4223
remove references to e10s force-enable pref that is no longer used, r=ato,eeejay

Comment 9

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/83894232a6bd
https://hg.mozilla.org/mozilla-central/rev/139abe6b4223