Closed Bug 1549855 Opened 6 months ago Closed 6 months ago

Tidy up dead code trying to use browser.tabs.remote.force-enable in tests

Categories

(Firefox :: General, defect, P1)

68 Branch
defect

Tracking

()

RESOLVED FIXED
Firefox 68
Tracking Status
firefox68 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

Details

Attachments

(2 files)

See https://searchfox.org/mozilla-central/search?q=remote.force-enable&case=false&regexp=false&path=

bug 1548941 removes the nsAppRunner usage.

The mobile usage is dead, AFAIK, in that nothing I think ever uses e10s-based fennec, and I don't think anything much works at all if you try and enable it.

The test instances either set it at runtime (which does nothing) or use it together with browser.tabs.remote.autostart, so it has no effect.

Type: defect → task

Gah, I screwed up - I don't think https://searchfox.org/mozilla-central/source/toolkit/components/extensions/test/xpcshell/head_e10s.js#6 is actually dead. I mean, it is now, but it wasn't. Assuming I'm not wrong this time, those tests are now running in non-e10s when they shouldn't be.

Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Type: task → defect
Priority: P3 → P1

(In reply to :Gijs (he/him) from comment #1)

Gah, I screwed up - I don't think https://searchfox.org/mozilla-central/source/toolkit/components/extensions/test/xpcshell/head_e10s.js#6 is actually dead. I mean, it is now, but it wasn't. Assuming I'm not wrong this time, those tests are now running in non-e10s when they shouldn't be.

Hopefully, this is less bad than I feared - https://phabricator.services.mozilla.com/D31416#924078 .

Attachment #9065355 - Attachment description: Bug 1549855 - actually run webextension xpcshell tests using e10s, r?aswan → Bug 1549855 - actually run webextension xpcshell tests using e10s, r?zombie
Attachment #9065356 - Attachment description: Bug 1549855 - remove references to e10s force-enable pref that is no longer used, r?ato!,snorp!,surkov! → Bug 1549855 - remove references to e10s force-enable pref that is no longer used, r?ato,snorp,eeejay
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9383ea5938fe
actually run webextension xpcshell tests using e10s, r=zombie
https://hg.mozilla.org/integration/autoland/rev/928038c23227
remove references to e10s force-enable pref that is no longer used, r=ato,snorp,eeejay
See Also: → 1552442

(In reply to Arthur Iakab [arthur_iakab] from comment #6)

Backed out 2 changesets (bug 1549855) for failing Android mochitests on robocop_text_page.html CLOSED TREE

Ugh. I moved the android stuff to bug 1552442. I'm not sure if it's worth investing in it at this point; perhaps the force-enable pref can stay the way it is and only have an effect on android, or something like that (it's already not in all.js so it won't show up in about:config).

I'll reland with all the other changes.

Flags: needinfo?(gijskruitbosch+bugs)
Attachment #9065356 - Attachment description: Bug 1549855 - remove references to e10s force-enable pref that is no longer used, r?ato,snorp,eeejay → Bug 1549855 - remove references to e10s force-enable pref that is no longer used, r?ato,eeejay
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/83894232a6bd
actually run webextension xpcshell tests using e10s, r=zombie
https://hg.mozilla.org/integration/autoland/rev/139abe6b4223
remove references to e10s force-enable pref that is no longer used, r=ato,eeejay
Summary: Tidy up dead code trying to use browser.tabs.remote.force-enable at runtime and/or for fennec → Tidy up dead code trying to use browser.tabs.remote.force-enable in tests
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
You need to log in before you can comment on or make changes to this bug.