1549945 - [Automated review] "'<function>' is not defined. no-undef (eslint)" occurs when using "!" syntax in mochitest.ini

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, defect, P3)

Description

[Makoto Kato [:m_kato]]

Phabricator URL: https://phabricator.services.mozilla.com/D29153

mochitest's support-files supports "!" prefix to include other directory's file. When using this syntax, eslint doesn't load external file.

mochitest.ini

support-files =
  ...
  !/editor/libeditor/tests/spellcheck.js

[test_bug1418629.html]

test_bug1418629.html

...
<script src="/tests/editor/libeditor/tests/spellcheck.js"></script>
...
<script>
....
isSpellingCheckOk(SpecialPowers.wrap(input).editor, misspeltWords);

isSpellingCheckOk is defined in /tests/editor/libeditor/tests/spellcheck.js, but ./mach eslint says no-undef.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:sylvestre, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1549945 - Avoid the need for import-globals-from when (x)html files load scripts via /tests/. r?Mossop!

When loading from /tests/ we can strip off the /tests/ part and find the file with the rest of the path.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8ad04c95f25
Avoid the need for import-globals-from when (x)html files load scripts via /tests/. r=mossop

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/e8ad04c95f25