Open Bug 1550014 Opened 1 year ago Updated 10 months ago

Allow sorting by table column on compare subtest page

Categories

(Tree Management :: Perfherder, enhancement, P3)

enhancement

Tracking

(Not tracked)

People

(Reporter: whimboo, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 5 obsolete files)

Type: defect → enhancement
Priority: -- → P3
Assignee: nobody → alexandru.ionescu
Attachment #9092278 - Attachment is obsolete: true
Attachment #9090031 - Attachment is obsolete: true
Attachment #9089986 - Attachment is obsolete: true
Attachment #9089793 - Attachment is obsolete: true
Attachment #9089369 - Attachment is obsolete: true
Status: NEW → ASSIGNED

Could you provide an update on this Alex?

Flags: needinfo?(alexandru.ionescu)

The task is done in my side, igoldan told me that this will be merged in the next iteration or something?

Flags: needinfo?(alexandru.ionescu) → needinfo?(igoldan)

(In reply to Alexandru Ionescu :alexandrui from comment #8)

The task is done in my side, igoldan told me that this will be merged in the next iteration or something?

We've experimented with react-table and noticed it provides the same mechanics , it's easy to integrate & feature rich.
Thus, we should rethink the implementation.

Flags: needinfo?(igoldan)
No longer blocks: 1568462

We've experimented with react-table and noticed it provides the same mechanics , it's easy to integrate & feature rich.
Thus, we should rethink the implementation.

React-table is a useful library. However, it seems most useful if you need a simple table with specific functionality and pagination. When I looked into it before starting the compare view, the pagination was not an optional feature and there wasn't a need for the search and sort features it offers and the custom components for different columns would be required either way. Regarding the server side sorting, I think it'd be easy to implement it without doing the work to switch to react table. But if you think the features it offers is worth it, I'm not opposed :)

Assignee: aionescu → igoldan
No longer blocks: 1570944

We won't revisit this in 2020/Q1.

Assignee: igoldan → nobody
Status: ASSIGNED → NEW
You need to log in before you can comment on or make changes to this bug.