1550014 - Allow sorting by table column on compare subtest page

Status: RESOLVED FIXED

(Tree Management :: Perfherder, enhancement, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

It would be great if sorting by columns would be possible for the compare subtest page. It could be used to find the min/max values, or order the name of tests.

https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=try&newProject=try&originalRevision=9c50a8779f3f2520a0c14a318f557b29b7445d91&newRevision=8b80929cca79b03383726fe97a22624a1061ed60&originalSignature=2009309&newSignature=2009309&framework=10

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/5326

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/5330

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/5331

Comment 4

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/5332

Comment 5

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/5361

Comment 6

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/5362

Comment 7

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Could you provide an update on this Alex?

Comment 8

[Alexandru Ionescu (needinfo me) [:alexandrui]]

The task is done in my side, igoldan told me that this will be merged in the next iteration or something?

Comment 9

[Ionuț Goldan [:igoldan]]

(In reply to Alexandru Ionescu :alexandrui from comment #8)

The task is done in my side, igoldan told me that this will be merged in the next iteration or something?

We've experimented with react-table and noticed it provides the same mechanics , it's easy to integrate & feature rich.
Thus, we should rethink the implementation.

Comment 10

[Sarah Clements [:sclements]]

We've experimented with react-table and noticed it provides the same mechanics , it's easy to integrate & feature rich.
Thus, we should rethink the implementation.

React-table is a useful library. However, it seems most useful if you need a simple table with specific functionality and pagination. When I looked into it before starting the compare view, the pagination was not an optional feature and there wasn't a need for the search and sort features it offers and the custom components for different columns would be required either way. Regarding the server side sorting, I think it'd be easy to implement it without doing the work to switch to react table. But if you think the features it offers is worth it, I'm not opposed :)

Comment 11

[Ionuț Goldan [:igoldan]]

We won't revisit this in 2020/Q1.

Comment 12

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/6801