1550022 - nssutil3 doesn't get built on Android

Status: RESOLVED FIXED

(NSS :: Build, defect)

Description

[Edouard Oger [:eoger]]

From #nss on Slack:

Does anybody know why we are not including nssutil in these specific conditions here: https://searchfox.org/mozilla-central/rev/e7d9a8749303b39dadcc0e18ea0d60a570a68145/security/nss/lib/freebl/freebl.gyp#185
I've checked other parts of the tree and I'm not seeing that condition anywhere else.
I "assume" it's a mistake that wasn't caught because Firefox builds with moz_fold_libs=1 anyway, but I could be wrong so maybe someone has more context.

No one objected so far and this is blocking me from building NSS for Android, so I'll post a patch.

Comment 1

[Edouard Oger [:eoger]]

More investigation:

1. This is what introduced that "Linux or Android" condition initially: https://hg.mozilla.org/projects/nss/rev/7b9f0d09ca8b4d88d99b36d5e0806831fe70b8a5, which was a mistake in regards to bug 438870: only Linux targets should be nssutil3 free.
2. From then it was solidified and formalized into the build system in the big refactoring done here https://hg.mozilla.org/projects/nss/diff/be2b4287467076d42bb41021a3a10aa47a3eeb47/lib/freebl/freebl.gyp

So I believe we can safely alter that condition back to its original meaning.

Comment 2

[Edouard Oger [:eoger]]

Attachment: Bug 1550022 - Include nssutil3 in freebl Android builds.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a task, but please change it back in case of error.

Comment 4

[J.C. Jones [:jcj] (he/they)]

https://hg.mozilla.org/projects/nss/rev/d8c3be523da5fe81f11ad6f7228b20d85b67a24d