1550041 - freebl not building on iOS simulator

Status: RESOLVED FIXED

(NSS :: Build, defect)

Description

[Edouard Oger [:eoger]]

Here's what I'm getting:

[368/782] CC obj/lib/freebl/gcm-aes-x86_c_lib.gcm-x86.o
FAILED: obj/lib/freebl/gcm-aes-x86_c_lib.gcm-x86.o
cc -MMD -MF obj/lib/freebl/gcm-aes-x86_c_lib.gcm-x86.o.d '-DSHLIB_SUFFIX="dylib"' '-DSHLIB_PREFIX="lib"' '-DSHLIB_VERSION="3"' '-DSOFTOKEN_SHLIB_VERSION="3"' -DRIJNDAEL_INCLUDE_TABLES -DMP_API_COMPATIBLE -DHAVE_INT128_SUPPORT -DNSS_FIPS_DISABLED -DNSS_NO_INIT_SUPPORT -DNSS_X86_OR_X64 -DNSS_X64 -DNSS_USE_64 -DUSE_UTIL_DIRECTLY -DNO_NSPR_10_SUPPORT -DSSL_DISABLE_DEPRECATED_CIPHER_SUITE_NAMES -DHAVE_BSD_FLOCK -DHAVE_STRERROR -DXP_UNIX -D_REENTRANT -DDARWIN -DNSS_DISABLE_DBM -DNSS_DISABLE_LIBPKIX -DNDEBUG -I../../lib/freebl/mpi -I../../lib/freebl/ecl -I../../lib/freebl/verified -I/Users/eoger/bobo/nss-3.43/nspr_dist/dist/include/nspr -I/Users/eoger/bobo/nss-3.43/nss_dist/private/nss -I/Users/eoger/bobo/nss-3.43/nss_dist/nss -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator12.2.sdk -fasm-blocks -mpascal-strings -O2 -gdwarf-2 -mios-simulator-version-min=11.0 -arch x86_64 -fPIC -fno-common -pipe -Werror -Wall -Wno-array-bounds -Wno-unevaluated-expression -Wno-parentheses-equality -Qunused-arguments -Wshadow  -c ../../lib/freebl/gcm-x86.c -o obj/lib/freebl/gcm-aes-x86_c_lib.gcm-x86.o
../../lib/freebl/gcm-x86.c:61:13: error: '__builtin_ia32_pclmulqdq128' needs target feature pclmul
        C = _mm_clmulepi64_si128(Ci, ghash->h, 0x00);
            ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/10.0.1/include/__wmmintrin_pclmul.h:59:13: note: expanded from macro '_mm_clmulepi64_si128'
  ((__m128i)__builtin_ia32_pclmulqdq128((__v2di)(__m128i)(X), \
            ^
../../lib/freebl/gcm-x86.c:62:13: error: '__builtin_ia32_pclmulqdq128' needs target feature pclmul
        D = _mm_clmulepi64_si128(Ci, ghash->h, 0x11);
            ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/10.0.1/include/__wmmintrin_pclmul.h:59:13: note: expanded from macro '_mm_clmulepi64_si128'
  ((__m128i)__builtin_ia32_pclmulqdq128((__v2di)(__m128i)(X), \
            ^
../../lib/freebl/gcm-x86.c:63:13: error: '__builtin_ia32_pclmulqdq128' needs target feature pclmul
        E = _mm_clmulepi64_si128(Ci, ghash->h, 0x01);
            ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/10.0.1/include/__wmmintrin_pclmul.h:59:13: note: expanded from macro '_mm_clmulepi64_si128'
  ((__m128i)__builtin_ia32_pclmulqdq128((__v2di)(__m128i)(X), \
            ^
../../lib/freebl/gcm-x86.c:64:13: error: '__builtin_ia32_pclmulqdq128' needs target feature pclmul
        F = _mm_clmulepi64_si128(Ci, ghash->h, 0x10);
            ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/10.0.1/include/__wmmintrin_pclmul.h:59:13: note: expanded from macro '_mm_clmulepi64_si128'
  ((__m128i)__builtin_ia32_pclmulqdq128((__v2di)(__m128i)(X), \
            ^
4 errors generated.
[370/782] CC obj/lib/freebl/gcm-aes-x86_c_lib.aes-x86.o
FAILED: obj/lib/freebl/gcm-aes-x86_c_lib.aes-x86.o
cc -MMD -MF obj/lib/freebl/gcm-aes-x86_c_lib.aes-x86.o.d '-DSHLIB_SUFFIX="dylib"' '-DSHLIB_PREFIX="lib"' '-DSHLIB_VERSION="3"' '-DSOFTOKEN_SHLIB_VERSION="3"' -DRIJNDAEL_INCLUDE_TABLES -DMP_API_COMPATIBLE -DHAVE_INT128_SUPPORT -DNSS_FIPS_DISABLED -DNSS_NO_INIT_SUPPORT -DNSS_X86_OR_X64 -DNSS_X64 -DNSS_USE_64 -DUSE_UTIL_DIRECTLY -DNO_NSPR_10_SUPPORT -DSSL_DISABLE_DEPRECATED_CIPHER_SUITE_NAMES -DHAVE_BSD_FLOCK -DHAVE_STRERROR -DXP_UNIX -D_REENTRANT -DDARWIN -DNSS_DISABLE_DBM -DNSS_DISABLE_LIBPKIX -DNDEBUG -I../../lib/freebl/mpi -I../../lib/freebl/ecl -I../../lib/freebl/verified -I/Users/eoger/bobo/nss-3.43/nspr_dist/dist/include/nspr -I/Users/eoger/bobo/nss-3.43/nss_dist/private/nss -I/Users/eoger/bobo/nss-3.43/nss_dist/nss -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator12.2.sdk -fasm-blocks -mpascal-strings -O2 -gdwarf-2 -mios-simulator-version-min=11.0 -arch x86_64 -fPIC -fno-common -pipe -Werror -Wall -Wno-array-bounds -Wno-unevaluated-expression -Wno-parentheses-equality -Qunused-arguments -Wshadow  -c ../../lib/freebl/aes-x86.c -o obj/lib/freebl/gcm-aes-x86_c_lib.aes-x86.o
../../lib/freebl/aes-x86.c:153:13: error: always_inline function '_mm_aesenc_si128' requires target feature 'aes', but would be inlined into function 'rijndael_native_encryptBlock' that is compiled without support for 'aes'
        m = _mm_aesenc_si128(m, cx->keySchedule[i]);
            ^
../../lib/freebl/aes-x86.c:155:9: error: always_inline function '_mm_aesenclast_si128' requires target feature 'aes', but would be inlined into function 'rijndael_native_encryptBlock' that is compiled without support for 'aes'
    m = _mm_aesenclast_si128(m, cx->keySchedule[cx->Nr]);
        ^
2 errors generated.
ninja: build stopped: subcommand failed.

Patch incoming

Comment 1

[Edouard Oger [:eoger]]

Attachment: Bug 1550041 - Pass -mpclmul to iOS targets. r?jcj,KevinJacobs

Comment 2

[J.C. Jones [:jcj] (he/they)]

https://hg.mozilla.org/projects/nss/rev/138b2bd6f91d4158942a7087f0f39b520252c960