1550074 - Firefox doesn't restart after being updated via package manager on Linux

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[mathieu.tarral]

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:66.0) Gecko/20100101 Firefox/66.0

Steps to reproduce:

I updated Firefox on Fedora using my package manager dnf.
I was aked to restart Firefox, and clicked "restart" button.

I was running Firefox 66.0.x, and I updated to the latest version available: 66.0.4

Actual results:

Firefox process terminated, but didn't retarted

Expected results:

Firefox should have restarted

Comment 1

[ovidiu boca[:Ovidiu]]

Hi Mathieu, I've tested this on Ubuntu 16.04 with FF release 66.0.4 and I was able to update the version to FF release 66.0.5. Please try to update to FF release 66.0.5.

Comment 2

[mathieu.tarral]

Hi,

thanks for the reply.

I just upgraded to Firefox 66.0.5 this evening, and i started a desktop capture to show you that Firefox doesn't restart.

Please look at the next attachment.

Thanks !

Comment 3

[mathieu.tarral]

Attachment: firefox_no_restart.mp4

Video demonstrating a Firefox 66.0.4, running on Fedora 29.

I started a DNF system upgrade, and Firefox has already been upgraded in the background to 66.0.5.

I'm waiting for Firefox to detect it, and then to click on restart, only to see that Firefox doesn't restart as expected.

Comment 4

[Michiel Dethmers]

I can confirm the same thing is happening on Ubuntu 18.04.2 LTS
just upgrade to FF 67.0.1 (64-bit)

Comment 5

[Roscoe Primrose]

I’m seeing the same thing on two different computers using Ubuntu Mate. This has been happening for at least the last 10 updates.

Comment 6

[mathieu.tarral]

Hi,

I'm the bug reporter, 5 months ago, and this is still happening today (Firefox 69.0.1).

Other people confirmed it, so what's the status of this bug ?
Have you been investigating ?

Comment 7

[mathieu.tarral]

Hi,

This happened again, with Firefox 68.0.2

Comment 8

[Machiel]

I can confirm this issue on Ubuntu 16.04/18.04 & Mint 19.2 with FF 70 We also have the tabs not reloading after manually starting the browser.

Especially the last part is quite disruptive for our users.

Comment 9

[Anthony K]

I can also confirm this to be the case on Ubuntu 20.04.1 LTS when I clicked restart after Firefox was updated to v80.0.

Comment 10

[Anthony K]

Attachment: Selection_00760.png

Comment 11

[ZaWertun]

There is bug when Firefox tries to restart itself with call to the "execve".
If I run Firefox under the strace I'll see this output while clicking "Restart Firefox" button:

readlink("/proc/self/exe", "/usr/lib64/firefox/firefox (dele"..., 4095) = 36
execve("/usr/lib64/firefox/firefox (deleted)", ["/usr/lib64/firefox/firefox"], 0x7f0aad04f000 /* 112 vars */) = -1 ENOENT (No such file or directory)

To fix this bug call to the "execve" must be replaced with something like "fexecve", see this stackoverflow question: https://stackoverflow.com/questions/28953307/how-to-handle-readlink-of-proc-self-exe-when-executable-is-replaced-during.

Comment 12

[ZaWertun]

Similar bugs in the Fedora bugtracker (I'm using Firefox on the Fedora x86_64).

1. https://bugzilla.redhat.com/show_bug.cgi?id=1876214
2. https://bugzilla.redhat.com/show_bug.cgi?id=1804293.

Comment 13

[ZaWertun]

The code I'm talking about is placed in the file "ipc/chromium/src/base/process_util_linux.cc", function bool LaunchApp(argv, options, process_handle).

Comment 14

[ZaWertun]

Firefox code that was calling readlink is not taking into account that returned path on Linux can include postfix " (deleted)".
(see: https://stackoverflow.com/a/58105245).

And because returned path ends with "firefox (deleted)" - we got ENOENT later, when calling execve.

Comment 15

[ZaWertun]

Attachment: firefox-fix-restart.patch

This small patch removes postfix " (deleted)" from the exe path, so issue with restart will be fixed.

Comment 16

[ZaWertun]

Bug can be simply reproduced with this steps:

1. Start Firefox;
2. Run those commands in terminal:

sudo mv /usr/lib64/firefox/firefox /usr/lib64/firefox/firefox.new`;
sudo cp -v /usr/lib64/firefox/firefox.new /usr/lib64/firefox/firefox

3. Open page about:restartrequired in the Firefox and click button "Restart Firefox".

Before patch Firefox won't restart.
After patch applied Firefox restarts as expected.

Comment 17

[Martin Stránský [:stransky] (ni? me)]

Great! Please submit the patch via phabricator so we can check it into mozilla tree (https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html).
Thanks.

Comment 18

[ZaWertun]

Attachment: Bug 1550074 - Firefox doesn't restart after being updated via package manager on Linux

Comment 19

[ZaWertun]

Just submitted patch on phabricator + there is fixed version of test plan in the comments.

Comment 20

[ZaWertun]

https://phabricator.services.mozilla.com/D89938

Comment 21

[Martin Stránský [:stransky] (ni? me)]

Thanks a lot!

Comment 22

[Martin Stránský [:stransky] (ni? me)]

ZaWertun, can you please regenerate the patch? it must be without the "firefox" prefix in filename path, i.e. "xpcom/build/BinaryPath.h" instead of "firefox/xpcom/build/BinaryPath.h".
Thanks.

Comment 23

[ZaWertun]

Attachment: firefox-fix-restart.patch

Comment 24

[ZaWertun]

Attachment: firefox-fix-restart.patch

Comment 25

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:zawertun, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 26

[Martin Stránský [:stransky] (ni? me)]

ZaWertun, please update the patch in Phabricator. It can't be landed from Bugzilla.
Thanks.

Comment 27

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1550074 - Firefox doesn't restart after being updated via package manager on Linux, r?jhorak

Regenerated the patch behalf of zawertun user.

Comment 28

[Martin Stránský [:stransky] (ni? me)]

I regenerated the patch as a new one to allow check-in.

Comment 29

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f903eb4c6a07
Firefox doesn't restart after being updated via package manager on Linux, r=jhorak

Comment 30

[Alexandru Michis [:malexandru]]

Backed out changeset f903eb4c6a07 (Bug 1550074) for causing bustages in BinaryPath.h

Backout link: https://hg.mozilla.org/integration/autoland/rev/39e0953861ec7034d6f180c5e152836e4e02ef92

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=f903eb4c6a073685da5f9584bab0afdf4608eebf&selectedTaskRun=LvzWxil2R4mmYSHEYzx3jQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=322655028&repo=autoland&lineNumber=4916

Comment 31

[Martin Stránský [:stransky] (ni? me)]

Updated, Thanks.
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=367989ec72148fb3ee2233e879b1a1d336db784b

Comment 32

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a888688ae24e
Firefox doesn't restart after being updated via package manager on Linux, r=jhorak

Comment 33

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/a888688ae24e