1550103 - Deleting a selected login with undo

Status: NEW

(Firefox :: about:logins, enhancement, P3)

Description

[Jared Wein [:jaws] (please needinfo? me)]

When viewing a LoginItem, the user should have the ability to delete a login. The user should either confirm that they intend to delete the login or be provided with the ability to undo their deletion.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Some notes from the UX review:

• On delete, move to login that preceded the deleted match. If top, move to next in list. If no logins remain, show empty state text
• Add in “undo” feature on delete.

This bug will no longer need the modal dialog. When a login is deleted, there should be Undo text that appears at the top of the login-item area that allows for undoing the delete. The undo text should remain for 15 seconds. There should be an X to clear the undo. Changing to another login or clicking 'New Login' will also clear the undo.

Comment 2

[Sandy Sage]

Undo would be great. But let's make that a separate bug so we can prioritize it with the rest of our remaining work to get the basic management UI in place for Fx70. If we separate that out, what else would be remaining on this bug?

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

There is a work-in-progress patch for the delete-with-modal-dialog on bug 1550110, so we could keep this bug for the 'undo' feature and rename bug 1550110 to cover the delete warning dialog.