1550115 - Addition of Pocket ID to SPOC endpoint requests

Status: RESOLVED FIXED

(Firefox :: New Tab Page, task, P1)

Description

[Scott [:thecount] Downe]

With Adzerk, we need to be passing a pocket user id to the spoc request.

Comment 1

[Scott [:thecount] Downe]

Attachment: GitHub Pull Request

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5058

Comment 3

[Scott [:thecount] Downe]

Chatted with Digi today, to double check something. Looks like we'll need to send the id over with a post and not a get. Currently the spoc request is a get, and it passes consumer_key along as a query param. If we move this over to a post, and include the pocket impression_id as a payload item, I'll also want to send consumer_key over as a payload item too.

The payload changes I'll be sending in the spoc request post are:

{
  consumer_key: "abcd",
  impression_id: "abcd",
}

Mathijs, does that make sense to you, and is there something separate you need to track for any potential changes needed to be made on the back end?

Comment 4

[Mathijs Miermans]

I'll make sure the Proxy Server accepts a Post request. I'll let you know when the OpenAPI spec is ready.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:tspurway, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 6

[Scott [:thecount] Downe]

To test:

1. Set browser.newtabpage.activity-stream.discoverystream.config to default
2. In browser console, open up the network tab and probably clear it.
3. in about:config, change browser.newtabpage.activity-stream.discoverystream.config to {"api_key_pref":"extensions.pocket.oAuthConsumerKey","collapsible":true,"enabled":true,"show_spocs":true,"hardcoded_layout":true,"personalized":false,"layout_endpoint":"https://getpocket.cdn.mozilla.net/v3/newtab/layout?version=1&consumer_key=$apiKey&layout_variant=basic"}
4. In the network tab, you should now see a POST to unique-spocs and also check that requests params tab for something along these lines: {"pocket_id":"{123-123-123-123-123}","consumer_key":"123345678"}

Comment 7

[Scott [:thecount] Downe]

This got merged.

Comment 8

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/719da47cffec

Comment 9

[Scott [:thecount] Downe]

Attachment: GitHub Pull Request

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Is this something we need to uplift to Beta or can it ride the trains?

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Assuming that's a no then.

Comment 12

[Scott [:thecount] Downe]

You are correct we don't need this uplifted, 69 is fine.