1550137 - Import button for migrator

Status: VERIFIED FIXED

(Firefox :: about:logins, enhancement, P2)

Description

[Jared Wein [:jaws] (please needinfo? me)]

This button should be in the Ellipsis menu and only available on Windows since we only have migrators for Windows currently.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1550137 - Import button for migrator in the about:logins menu. r?gijs

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1550137 - Change from aria-hidden to HTML5 hidden. r?MattN

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c8faa218f64
Import button for migrator in the about:logins menu. r=Gijs,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/e6cc0fd6e665
Change from aria-hidden to HTML5 hidden. r=MattN

Comment 4

[Andreea Pavel [:apavel]]

Backed out for permafailing bug 1553196

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&selectedJob=251434675&revision=e6cc0fd6e66535653be810eb1be3675e59d5c5b0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=251428618&repo=autoland&lineNumber=2519

Backout: https://hg.mozilla.org/integration/autoland/rev/eac49b8b615824157da184d6eba34f70a88a91fa

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db2092bd295b
Import button for migrator in the about:logins menu. r=Gijs,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/d7b5c95addb1
Change from aria-hidden to HTML5 hidden. r=MattN

Comment 6

[Cristian Brindusan [:cbrindusan]]

Backed out 2 changesets (Bug 1550137) for bc failures at browser_masterPassword.js.

Backout: https://hg.mozilla.org/integration/autoland/rev/37e68e5fbb18940c4e8636f91dfd3071d5a6d7aa

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=d7b5c95addb11a8bd44b1c1b26301bb193df59cb&selectedJob=251723784

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=251723784&repo=autoland&lineNumber=2719

Comment 7

[Cristian Brindusan [:cbrindusan]]

There are also bc failures at browser_aaa_eventTelemetry_run_first.js.
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=251752280&repo=autoland&lineNumber=3048

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e5a8210ed47e
Import button for migrator in the about:logins menu. r=Gijs,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/cf814cb39d8e
Change from aria-hidden to HTML5 hidden. r=MattN

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/e5a8210ed47e
https://hg.mozilla.org/mozilla-central/rev/cf814cb39d8e

Comment 10

[Cristian Fogel [:cfogel]]

Confirmed with 69.0b7 on Windows 10; button displayed and starting the import action.
Other main operating systems: macOS 10.14, Ubuntu 18.04 do not have the option.