1550243 - [wpt-sync] Sync PR 16385 - Compute RTCPeerConnection iceConnectionState based on RTCIceTransport states.

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 16385 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/16385
Details from upstream follow.

Marina Ciocea <[e-mail]> wrote:

Compute RTCPeerConnection iceConnectionState based on RTCIceTransport states.

Previously both RTCPeerConnection::iceConnectionState and RTCIceTransport states
were calculated based on updates coming from webrtc layer to blink layer (from
signaling thread to main thread). Because there is no ordering between the two
updates, the peer connection iceConnectionState and ice transport states could
end up out of sync in blink layer. Fix state mismatch by updating the peer
connection iceConnectionState using blink layer ice transport states, on ice
transport state updates.

These changes only apply for unified plan because RTCIceTransport is not exposed
for plan B.

Bug: 953694,944036
Change-Id: I3b96189593a89715cc42a8113e97c2b31c7f0eb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566334
Commit-Queue: Marina Ciocea \<[e-mail]>
Reviewed-by: Henrik Boström \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#653116}

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=1305e61a671159c618a279aafda28365ae6884e7

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=6320af94763d475c0a2cac549a464f599a4a6527

Comment 3

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Failed to get results from try push

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/add942756682
[wpt PR 16385] - Compute RTCPeerConnection iceConnectionState based on RTCIceTransport states., a=testonly

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/add942756682