Closed Bug 155031 Opened 22 years ago Closed 22 years ago

Search by votes is shown even when votes are turned off

Categories

(Bugzilla :: Query/Bug List, defect)

2.16
x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 2.16

People

(Reporter: davef, Assigned: bbaetz)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

the section "Only bugs with at least: [  ]  votes" isn't being properly if'd out
when votes are turned off. Simple fix, patch provided.
Attached patch patch to fix the bug (obsolete) — Splinter Review
Comment on attachment 89702 [details] [diff] [review]
patch to fix the bug

This is going to conflict with my fix for bug 150829. I'll look into merging
this into my patch for that.
Depends on: 150829
Keywords: regression
Target Milestone: --- → Bugzilla 2.16
bbaetz didn't integrate this into the previous patch, but he said on IRC that
he'll look at this separately.
Summary: Section isn't being if'd out when votes are turned off → Search by votes is shown even when votes are turned off
Attached patch take 2Splinter Review
This uses the new param to check this, instead
Attachment #89702 - Attachment is obsolete: true
-> me
Assignee: endico → bbaetz
Comment on attachment 90711 [details] [diff] [review]
take 2

2xr=jouni
Attachment #90711 - Flags: review+
Checked in, trunk + branch
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: