1550341 - heap-use-after-free in nsHttpConnectionMgr::ResetIPFamilyPreference - data race to nsHttpConnectionInfo::mHashKey

Status: RESOLVED DUPLICATE of bug 1548822

(Core :: Networking, defect, P1)

Description

[Treeherder Bug Filer]

Filed by: apavel [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=245431311&repo=autoland
Full log: https://queue.taskcluster.net/v1/task/Bp_c_lN1S-C2o4jp3yVGfg/runs/0/artifacts/public/logs/live_backing.log

---

[task 2019-05-08T22:32:40.064Z] 22:32:40 INFO - TEST-START | netwerk/test/unit/test_altsvc.js
[task 2019-05-08T22:32:42.702Z] 22:32:42 WARNING - TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_altsvc.js | xpcshell return code: 1
[task 2019-05-08T22:32:42.702Z] 22:32:42 INFO - TEST-INFO took 2635ms
[task 2019-05-08T22:32:42.704Z] 22:32:42 INFO - >>>>>>>
[task 2019-05-08T22:32:42.705Z] 22:32:42 INFO - (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2019-05-08T22:32:42.706Z] 22:32:42 INFO - TEST-PASS | netwerk/test/unit/test_altsvc.js | run_test - [run_test : 26] "34243" != null
[task 2019-05-08T22:32:42.706Z] 22:32:42 INFO - TEST-PASS | netwerk/test/unit/test_altsvc.js | run_test - [run_test : 27] "34243" != ""
[task 2019-05-08T22:32:42.707Z] 22:32:42 INFO - PID 10556 | http foo - http://foo.example.com:39664/
[task 2019-05-08T22:32:42.707Z] 22:32:42 INFO - PID 10556 | https foo - https://foo.example.com:34243/
[task 2019-05-08T22:32:42.709Z] 22:32:42 INFO - PID 10556 | http bar - http://bar.example.com:40968/
[task 2019-05-08T22:32:42.709Z] 22:32:42 INFO - PID 10556 | https bar - https://bar.example.com:34243/
[task 2019-05-08T22:32:42.709Z] 22:32:42 INFO - PID 10556 | doTest1()
[task 2019-05-08T22:32:42.710Z] 22:32:42 INFO - (xpcshell/head.js) | test pending (2)
[task 2019-05-08T22:32:42.711Z] 22:32:42 INFO - PID 10556 | execute doTest http://foo.example.com:39664/
[task 2019-05-08T22:32:42.712Z] 22:32:42 INFO - (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2019-05-08T22:32:42.713Z] 22:32:42 INFO - running event loop
[task 2019-05-08T22:32:42.713Z] 22:32:42 INFO - "CONSOLE_MESSAGE: (info) No chrome package registered for chrome://branding/locale/brand.properties"
[task 2019-05-08T22:32:42.717Z] 22:32:42 INFO - TEST-PASS | netwerk/test/unit/test_altsvc.js | testOnStartRequest - [testOnStartRequest : 137] true == true

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: stack_trace.txt

Comment 2

[Valentin Gosu [:valentin] (he/him)]

The nsHttpConnectionInfo is sent to the socket thread from here but later on the main thread we change some attributes which causes nsHttpConnectionInfo::mHashKey to change.

Thoughts?