Closed Bug 1550359 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 16664 - Use PFFFT for WebAudio FFT on Android

Categories

(Core :: Web Audio, defect, P4)

Product:
Core
Component:
Web Audio
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 16664 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/16664
Details from upstream follow.

Raymond Toy <rtoy@chromium.org> wrote:

Use PFFFT for WebAudio FFT on Android

Replace the OpenMAX DL FFT with PFFFT for WebAudio on Android.

Roughly, the library is as fast or faster than OpenMAX DL FFT and is not
a giant blob of handwritten assembly code. See the bug for a link for
additional information.

The changes in the tests are due to minor changes in accuracy. Apparently,
PFFFT is very slightly less accurate than OpenMAX DL. We deem these small changes
to be acceptable for the performance gain and readability.

Bug: 917355
Change-Id: Ia3efdab06364e312608e2aa7e060c46a8c8d0885
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590257
Reviewed-by: Hongchan Choi \<hongchan@chromium.org>
Reviewed-by: Nico Weber \<thakis@chromium.org>
Commit-Queue: Raymond Toy \<rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656537}

Component: web-platform-tests → Web Audio
Product: Testing → Core
Failed to get results from try push
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ac1f3df29300
[wpt PR 16664] - Use PFFFT for WebAudio FFT on Android, a=testonly

https://hg.mozilla.org/mozilla-central/rev/ac1f3df29300

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.