1550389 - --enable-warnings-as-errors fails due to -D unused-mut with Rust 1.36

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Jan Beich]

$ rustc -vV
rustc 1.36.0-nightly
binary: rustc
commit-hash: 3f5152e200c0c02dfe0f79367948c98053d35855
commit-date: 2019-05-08
host: x86_64-unknown-freebsd
release: 1.36.0-nightly
LLVM version: 8.0

$ echo "ac_add_options --enable-warnings-as-errors" >>.mozconfig
$ ./mach build
[...]
error: variable does not need to be mutable
--> servo/components/style/properties/declaration_block.rs:1385:10
|
1385 | for (mut error, slice, property) in errors.drain() {
| ----^^^^^
| |
| help: remove this mut
|
= note: -D unused-mut implied by -D warnings
error: aborting due to previous error
error: Could not compile style.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

If only my local warnings weren't busted because of https://github.com/rust-lang/rust/issues/60050...

Comment 2

[Emilio Cobos Álvarez [:emilio]]

(Thanks for the report :))

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3390fa47ebcd
Remove unnecessary mut usage.

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/3390fa47ebcd