1550488 - Change the OTR localization to use Fluent

Status: RESOLVED FIXED

(Chat Core :: Security: OTR, enhancement)

Description

[Kai Engert [:KaiE:]]

The initial landing of the OTR code might still use the classic approach for localized strings.

We must port it to use Fluent.

Comment 1

[Kai Engert [:KaiE:]]

Attachment: otr-finger-fluent.patch

example for conversion to fluent

Comment 2

[Kai Engert [:KaiE:]]

Attachment: 1550488-v2.patch

two dialogs done now...

Also fixes the problem with the ask-for-auth dialog, the <caption> had stopped working. Replaced it with html:h4

Comment 3

[Kai Engert [:KaiE:]]

Attachment: 1550488-v3.patch

Comment 4

[Kai Engert [:KaiE:]]

Attachment: 1550488-v4.patch

Comment 5

[Kai Engert [:KaiE:]]

Note to self:

If this gets checked in prior to being done with our strings, the .ftl files must be committed to a location outside of the locale/en-US directory, to avoid that localizers work on unfinished strings.

An example how to do that can be found here:
https://searchfox.org/mozilla-central/source/browser/locales/jar.mn#11

Comment 6

[Kai Engert [:KaiE:]]

searchfox contents might move, therefore I'm pasting the example:

[localization] @AB_CD@.jar:
  browser/aboutLogins.ftl                          (../components/aboutlogins/content/aboutLogins.ftl)
  browser                                          (%browser/**/*.ftl)

Comment 7

[Kai Engert [:KaiE:]]

Attachment: 1550488-v5.patch

Adjusted to apply on top of bug 1518172.

Moved all .ftl files out of the locales scope for now.

Comment 8

[Kai Engert [:KaiE:]]

Comment on attachment 9065641 [details] [diff] [review]
1550488-v5.patch

Magnus can you please review?

If you want a phabricator request, I can do that soon, after bug 1518172 lands (probably today).

Comment 9

[Kai Engert [:KaiE:]]

Attachment: Bug 1550488, Change the OTR localization to use Fluent

Change the OTR localization to use Fluent

Comment 10

[Kai Engert [:KaiE:]]

Comment on attachment 9065641 [details] [diff] [review]
1550488-v5.patch

let's use phab

Comment 11

[Kai Engert [:KaiE:]]

Attachment: 1550488-final.patch

Comment 12

[Kai Engert [:KaiE:]]

Jörg, can you please land the attached patch? Reviewed in phab. Thanks!

Comment 13

[Kai Engert [:KaiE:]]

Attachment: 1550488-with-commit-header.patch

Comment 14

[Jorg K (CEST = GMT+2)]

You should run linting before submitting a patch :-( - I'll fix it for you now:

c:\mozilla-source\comm-central\comm\chat\modules\OTR.jsm
12:3 error 'XPCOMUtils' is assigned a value but never used. no-unused-vars (eslint)
13:3 error 'l10nHelper' is assigned a value but never used. no-unused-vars (eslint)
21:26 error Missing trailing comma. comma-dangle (eslint)

c:\mozilla-source\comm-central\comm\chat\modules\OTRUI.jsm
11:3 error 'XPCOMUtils' is assigned a value but never used. no-unused-vars (eslint)
12:3 error 'l10nHelper' is assigned a value but never used. no-unused-vars (eslint)
17:28 error Missing trailing comma. comma-dangle (eslint)

? 6 problems (6 errors, 0 warnings)

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ae087d73b3ce
Change the OTR localization to use Fluent. r=mkmelin

Comment 16

[Kai Engert [:KaiE:]]

(In reply to Jorg K (GMT+2) from comment #14)

You should run linting before submitting a patch :-( - I'll fix it for you now:

Yes, I should have, thanks a lot for your help!

Comment 17

[Kai Engert [:KaiE:]]

Attachment: 1550488-remove-dtd.patch

Jörg reported a failure:
"WARNING: Failed to open external DTD: publicId "" systemId "chrome://chat/content/otr-chat.dtd"

I should have removed it as part of this bug.

Comment 18

[Jorg K (CEST = GMT+2)]

Comment on attachment 9069972 [details] [diff] [review]
1550488-remove-dtd.patch

Thanks.

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fdc11cc83535
Follow-up: Remove reference to DTD file. r=jorgk

Comment 20

[Jorg K (CEST = GMT+2)]

TB 68 beta:
https://hg.mozilla.org/releases/comm-beta/rev/e133b7bcaa72fe28c4b32b62abb3d8e596fef882 (follow-up)