Change the OTR localization to use Fluent
Categories
(Chat Core :: Security: OTR, enhancement)
Tracking
(Not tracked)
People
(Reporter: KaiE, Assigned: KaiE)
References
(Blocks 1 open bug)
Details
Attachments
(2 files, 7 obsolete files)
65.24 KB,
patch
|
Details | Diff | Splinter Review | |
1.10 KB,
patch
|
jorgk-bmo
:
review+
jorgk-bmo
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
The initial landing of the OTR code might still use the classic approach for localized strings.
We must port it to use Fluent.
Assignee | ||
Comment 1•6 years ago
|
||
example for conversion to fluent
Assignee | ||
Comment 2•6 years ago
|
||
two dialogs done now...
Also fixes the problem with the ask-for-auth dialog, the <caption> had stopped working. Replaced it with html:h4
Assignee | ||
Comment 3•6 years ago
|
||
Assignee | ||
Comment 4•6 years ago
|
||
Assignee | ||
Comment 5•6 years ago
|
||
Note to self:
If this gets checked in prior to being done with our strings, the .ftl files must be committed to a location outside of the locale/en-US directory, to avoid that localizers work on unfinished strings.
An example how to do that can be found here:
https://searchfox.org/mozilla-central/source/browser/locales/jar.mn#11
Assignee | ||
Comment 6•6 years ago
|
||
searchfox contents might move, therefore I'm pasting the example:
[localization] @AB_CD@.jar:
browser/aboutLogins.ftl (../components/aboutlogins/content/aboutLogins.ftl)
browser (%browser/**/*.ftl)
Assignee | ||
Comment 7•6 years ago
|
||
Adjusted to apply on top of bug 1518172.
Moved all .ftl files out of the locales scope for now.
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 8•6 years ago
|
||
Assignee | ||
Comment 9•6 years ago
|
||
Change the OTR localization to use Fluent
Assignee | ||
Comment 10•6 years ago
|
||
Updated•6 years ago
|
Assignee | ||
Comment 11•6 years ago
|
||
Assignee | ||
Comment 12•6 years ago
|
||
Jörg, can you please land the attached patch? Reviewed in phab. Thanks!
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 13•6 years ago
|
||
Comment 14•6 years ago
|
||
You should run linting before submitting a patch :-( - I'll fix it for you now:
c:\mozilla-source\comm-central\comm\chat\modules\OTR.jsm
12:3 error 'XPCOMUtils' is assigned a value but never used. no-unused-vars (eslint)
13:3 error 'l10nHelper' is assigned a value but never used. no-unused-vars (eslint)
21:26 error Missing trailing comma. comma-dangle (eslint)
c:\mozilla-source\comm-central\comm\chat\modules\OTRUI.jsm
11:3 error 'XPCOMUtils' is assigned a value but never used. no-unused-vars (eslint)
12:3 error 'l10nHelper' is assigned a value but never used. no-unused-vars (eslint)
17:28 error Missing trailing comma. comma-dangle (eslint)
? 6 problems (6 errors, 0 warnings)
Comment 15•6 years ago
|
||
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/ae087d73b3ce
Change the OTR localization to use Fluent. r=mkmelin
Updated•6 years ago
|
Assignee | ||
Comment 16•6 years ago
|
||
(In reply to Jorg K (GMT+2) from comment #14)
You should run linting before submitting a patch :-( - I'll fix it for you now:
Yes, I should have, thanks a lot for your help!
Assignee | ||
Comment 17•5 years ago
|
||
Jörg reported a failure:
"WARNING: Failed to open external DTD: publicId "" systemId "chrome://chat/content/otr-chat.dtd"
I should have removed it as part of this bug.
Assignee | ||
Updated•5 years ago
|
Comment 18•5 years ago
|
||
Comment 19•5 years ago
|
||
Comment 20•5 years ago
|
||
TB 68 beta:
https://hg.mozilla.org/releases/comm-beta/rev/e133b7bcaa72fe28c4b32b62abb3d8e596fef882 (follow-up)
Updated•5 years ago
|
Updated•5 years ago
|
Description
•