1550549 - Convert XUL textboxes to HTML inputs in pageInfo.xul

Status: RESOLVED FIXED

(Firefox :: Page Info Window, task, P3)

Comment 1

[Tim Nguyen :ntim]

Attachment: Bug 1550549 - Convert XUL textboxes to HTML inputs in pageInfo.xul

Comment 2

[Tim Nguyen :ntim]

The current patch works without bug 1562639 by adding data-l10n-attrs="value", bug 1562639 suggests this is intentional, so I guess that part is solved.

The remaining part is increasing the dialog spacing, since this patch decreased the spacing between rows and columns ... and also pushing it to try.

Comment 3

[Brian Grinstead [:bgrins]]

Attachment: Bug 1550549 - Add test coverage for a http domain in page info security tab

This was missing coverage which would have caught a bug during the development
of the previous patch (https://phabricator.services.mozilla.com/D30537#inline-289837)

Depends on D30537

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b02ae35438c9
Convert XUL textboxes to HTML inputs in pageInfo.xul r=fluent-reviewers,Gijs,flod
https://hg.mozilla.org/integration/autoland/rev/865a39c9635f
Add test coverage for a http domain in page info security tab r=Gijs

Comment 5

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/b02ae35438c9
https://hg.mozilla.org/mozilla-central/rev/865a39c9635f