Closed
Bug 1550671
Opened 5 years ago
Closed 5 years ago
Split `SelectionCopyHelper` to more informative sub-functions
Categories
(Core :: DOM: Serializers, enhancement)
Core
DOM: Serializers
Tracking
()
RESOLVED
FIXED
mozilla68
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: mbrodesser-Igalia, Assigned: mbrodesser-Igalia)
Details
Attachments
(1 file)
No description provided.
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → mbrodesser
|
|
Assignee | |
Updated•5 years ago
|
Summary: Simplify detecting if `nsHTMLCopyEncoder` changes `mimeType` to "text/plain" → Split `SelectionCopyHelper` to more informative sub-functions
|
|
Assignee | |
Comment 1•5 years ago
|
||
The name SelectionCopyHelper didn't state what the function does.
Now, instead of SelectionCopyHelper, the following two call sequences
exist:
EncodeDocumentWithContext,PutToClipboard.EncodeDocumentWithContextAndCreateTransferable, calling
EncodeDocumentWithContextand
CreateTransferable.
Apart from additional nullptr checks, the semantics didn't change.
|
|
Assignee | |
Updated•5 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 2•5 years ago
|
||
Requesting checkin. A corresponding try run has only unrelated failures.
Pushed by ncsoregi@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2c353f21c1dc
split SelectionCopyHelper to more informative functions r=hsivonen
Keywords: checkin-needed
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in
before you can comment on or make changes to this bug.
Description
•