Closed Bug 1550671 Opened 6 years ago Closed 6 years ago

Split `SelectionCopyHelper` to more informative sub-functions

Categories

(Core :: DOM: Serializers, enhancement)

Product:
Core
Component:
DOM: Serializers
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: mbrodesser-Igalia, Assigned: mbrodesser-Igalia)

Details

Attachments

(1 file)

Bug 1550671: split `SelectionCopyHelper` to more informative functions
47 bytes, text/x-phabricator-request
Details | Review
No description provided.
Assignee: nobody → mbrodesser
Summary: Simplify detecting if `nsHTMLCopyEncoder` changes `mimeType` to "text/plain" → Split `SelectionCopyHelper` to more informative sub-functions

The name SelectionCopyHelper didn't state what the function does.
Now, instead of SelectionCopyHelper, the following two call sequences
exist:

  1. EncodeDocumentWithContext, PutToClipboard.
  2. EncodeDocumentWithContextAndCreateTransferable, calling
    EncodeDocumentWithContext and
    CreateTransferable.

Apart from additional nullptr checks, the semantics didn't change.

Requesting checkin. A corresponding try run has only unrelated failures.

Pushed by ncsoregi@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2c353f21c1dc
split SelectionCopyHelper to more informative functions r=hsivonen

Keywords: checkin-needed

https://hg.mozilla.org/mozilla-central/rev/2c353f21c1dc

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: