1550697 - The "Restart to update Firefox" menu item gives no visual indication when selected through the keyboard

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[B.J. Herbison]

When I use the keyboard to navigate through the hamburger menu the "Restart to update Firefox", unlike all the other items on the menu, does not give any visual indication when it is selected.

Steps to reproduce:

1. Wait patiently until there is an update ready to install. (I suggest using Nightly builds unless you are really bored.)
2. Open the hamburger menu.
3. Use up and down arrow to navigate through the menu.

Expected:

Each item should provide a visual indication when it is selected.

Actual:

Restart to update Firefox give no noticeable visual indication when it is selected.

This is a follow-on to bug 1444569 (The "restart to update Firefox" menu item is not accessible by arrow keys and Enter key).

Comment 1

[:Gijs (he/him)]

What OS? I see a focus outline on Windows...

(I'm guessing we just need to make the hover styling apply in the focused case, but either way...)

Comment 2

[B.J. Herbison]

Sorry, I should have mentioned I'm using the XFCE window manager on a computer running a Ubuntu distribution of Linux.

Comment 3

[:Gijs (he/him)]

Attachment: Bug 1550697 - fix focus colours for banners in hamburger menu, r?ntim

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ad581fafc85
fix focus colours for banners in hamburger menu, r=ntim

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/2ad581fafc85

Comment 6

[:Gijs (he/him)]

Comment on attachment 9065690 [details]
Bug 1550697 - fix focus colours for banners in hamburger menu, r?ntim

Beta/Release Uplift Approval Request

• User impact if declined: Some items won't look like they can receive keyboard focus in the hamburger menu
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: n/a
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): CSS-only change that adds some focus styling, loooooads of 68 runway.
• String changes made/needed: Nope

Comment 7

[B.J. Herbison]

I'm not an official Mozilla bug verifier, but as the the bug submitter the change looks good to me.

Comment 8

[:Gijs (he/him)]

Good enough for me! :-)

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 9065690 [details]
Bug 1550697 - fix focus colours for banners in hamburger menu, r?ntim

approved for 68.0b4, thanks

Comment 10

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/releases/mozilla-beta/rev/27768d2aff06