Closed Bug 1550860 Opened 5 months ago Closed 4 months ago

Mark implicit builtinclass interfaces explicitly

Categories

(Core :: XPCOM, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

Attachments

(1 file)

To simplify things, I want to land the large but boring patch to add builtinclass to interfaces that have notxpcom methods or attributes (or their parent interfaces do) separately. We have a explicit test for this implicit builtinclass behavior in NotXPCOMTest.idl, so that is still being used somewhere.

If an XPIDL interface has a method or attribute that is [notxpcom],
then it is implicitly treated as [builtinclass], even if it is not
marked as such. For clarity, this patch goes through and marks every
place that relies on this behavior (aside from some test code).

I wrote this patch by adding in a nonfatal version of the check I'm working on for bug 1550770, and then adding builtinclass to everything it complained about.

See Also: → 1550893
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b0c2b45643a2
Mark implicit builtinclass interfaces explicitly. r=nika
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.