Closed
Bug 1550860
Opened 7 years ago
Closed 7 years ago
Mark implicit builtinclass interfaces explicitly
Categories
(Core :: XPCOM, task, P3)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla68
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: mccr8, Assigned: mccr8)
References
Details
Attachments
(1 external file)
To simplify things, I want to land the large but boring patch to add builtinclass to interfaces that have notxpcom methods or attributes (or their parent interfaces do) separately. We have a explicit test for this implicit builtinclass behavior in NotXPCOMTest.idl, so that is still being used somewhere.
| Assignee | ||
Comment 1•7 years ago
|
||
If an XPIDL interface has a method or attribute that is [notxpcom],
then it is implicitly treated as [builtinclass], even if it is not
marked as such. For clarity, this patch goes through and marks every
place that relies on this behavior (aside from some test code).
| Assignee | ||
Comment 2•7 years ago
|
||
I wrote this patch by adding in a nonfatal version of the check I'm working on for bug 1550770, and then adding builtinclass to everything it complained about.
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b0c2b45643a2
Mark implicit builtinclass interfaces explicitly. r=nika
Comment 4•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in
before you can comment on or make changes to this bug.
Description
•