1550877 - browser.tabs.update fails for extension page

Status: RESOLVED FIXED

(GeckoView :: Extensions, defect, P1)

Description

[Christian Sadilek [:csadilek]]

When invoking browser.tabs.update for an extension page (an html page packaged with the extension) I see about:blank being loaded with the following errors in the console:

TypeError: E10SUtils is undefined in GeckoViewNavigation.jsm:159:11

[Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIDOMWindowUtils.removeSheetUsingURIString]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: resource://gre/modules/ExtensionCommon.jsm :: runSafeSyncWithoutClone :: line 65" data: no] ExtensionCommon.jsm:65:12
runSafeSyncWithoutClone resource://gre/modules/ExtensionCommon.jsm:65
cleanup resource://gre/modules/ExtensionContent.jsm:353
close resource://gre/modules/ExtensionContent.jsm:814
destroyed resource://gre/modules/ExtensionContent.jsm:889
observe resource://gre/modules/ExtensionContent.jsm:905

I did pass in the url as returned from browser.extension.getURL(...) which seems to have correctly resolved the moz-extension:// url.

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1550877 - Use correct E10SUtils in GeckoViewNavigation.

This fixes a crash in browser.tabs.update when used with WebExtension pages.

Comment 2

[Chris Peterson [:cpeterson]]

Christian, does the AC Reader View extension need this fix for Fenix MVP?

P1 crash regression from bug 1521549

Comment 3

[Christian Sadilek [:csadilek]]

I think so, yes. With this fix we can make the reader view extension much better, as it will allow us to properly isolate reader view from the original page (and from JavaScript that might be running there to display popups, ads, etc.).

Thanks for fixing this so quickly!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/877ae9359a27
Use correct E10SUtils in GeckoViewNavigation. r=snorp

Comment 5

[Narcis Beleuzu [:NarcisB]]

Backed out for causing perma geckoview-junit failures on contentPortDisconnectFromApp.

Backout link: https://hg.mozilla.org/integration/autoland/rev/55e45fc9d529196284843ed9a192e19edda6515c
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=246985987&repo=autoland&lineNumber=4311

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/566c25b14d47
Use correct E10SUtils in GeckoViewNavigation. r=snorp

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/566c25b14d47

Comment 8

[Chris Peterson [:cpeterson]]

Moving some extension bugs to the GeckoView::Extensions component.