Closed
Bug 155096
Opened 23 years ago
Closed 23 years ago
Crash when adding image with HSPACE and VSPACE to page with RTL text
Categories
(MailNews Core :: Internationalization, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.1beta
People
(Reporter: ilya.konstantinov+future, Assigned: smontagu)
References
Details
(Keywords: crash, rtl, Whiteboard: [adt2 RTM] [ETA 07/10])
Attachments
(2 files)
|
3.32 KB,
text/plain
|
Details | |
|
976 bytes,
patch
|
mjudge
:
review+
kinmoz
:
superreview+
jud
:
approval+
|
Details | Diff | Splinter Review |
To reproduce:
1. Create a new mail message.
2. Write some Hebrew text.
3. Insert Image.
4. Choose an image file, select "Don't use alternative text", and in the
"Appearance" tab, select "Wrap to the left" and set both Spacing values to "10".
5. Click OK.
Kaboom!
|
||
Comment 1•23 years ago
|
||
can you post a Talkback ID ?
Severity: normal → critical
Keywords: stackwanted
|
Reporter | |
Comment 2•23 years ago
|
||
Yes, TB7866538X.
Also, a minor correction -- changing the image's spacing isn't required --
making it "Wrap to left" is enough.
|
|
||
Comment 3•23 years ago
|
||
Product -> Mail/News
Status: UNCONFIRMED → NEW
Component: Editor: Composer → Composition
Ever confirmed: true
Product: Browser → MailNews
Whiteboard: Need TB7866538X data
|
Assignee | |
Comment 4•23 years ago
|
||
|
|
Assignee | |
Comment 5•23 years ago
|
||
Taking, since the crash seems to be in my code.
|
|
Assignee | |
Comment 6•23 years ago
|
||
Comment on attachment 89827 [details] [diff] [review]
Patch: add missing error check
its fine. just abort if invalid line.
Attachment #89827 -
Flags: review+
Comment on attachment 89827 [details] [diff] [review]
Patch: add missing error check
sr=kin@netscape.com
Attachment #89827 -
Flags: superreview+
|
|
Assignee | |
Comment 9•23 years ago
|
||
Fix checked in.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
|
||
Comment 10•23 years ago
|
||
gayatri/paw - who can verify this fix on the trunk?
Blocks: 143047
Keywords: approval,
mozilla1.0.1
Whiteboard: [adt2 RTM] [ETA 07/10]
Target Milestone: --- → mozilla1.1beta
|
||
Comment 11•23 years ago
|
||
Maybe Laurel could take a look at this.
|
||
Comment 12•23 years ago
|
||
Esther, can you please verify this on the trunk.
QA Contact: sujay → esther
|
||
Comment 13•23 years ago
|
||
changing qa to an international qa, the component should have been
internationalization
Component: Composition → Internationalization
QA Contact: esther → ji
|
||
Comment 14•23 years ago
|
||
Verified with 2002-07-09-13-trunk build on W2K. It's fixed. Ilya, please feel
free to reopen it if you still see the crash on your linux system with the
latest trunk build.
Status: RESOLVED → VERIFIED
|
||
Comment 15•23 years ago
|
||
adding adt1.0.1+. Please get drivers approval before checking into the branch.
|
||
Updated•23 years ago
|
Attachment #89827 -
Flags: approval+
|
|
||
Comment 16•23 years ago
|
||
please checkin to the 1.0.1 branch. once there, remove the "mozilla1.0.1+"
keyword and add the "fixed1.0.1" keyword.
Keywords: mozilla1.0.1 → mozilla1.0.1+
Keywords: fixed1.0.1 → verified1.0.1
|
|
||
Comment 18•23 years ago
|
||
Verified as fixed with 07/11 branch build.
|
|
Reporter | |
Comment 19•23 years ago
|
||
Confirming. The problem is no longer reproducible.
|
||
Updated•20 years ago
|
Product: MailNews → Core
|
||
Comment 20•17 years ago
|
||
Mass-assigning the new rtl keyword to RTL-related (see bug 349193).
Keywords: rtl
|
||
Updated•17 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•