1551167 - All inspector sub-suites fail when run on a clean build `head.js import threw an exception`

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Julian Descottes [:jdescottes]]

STRs:

• ./mach clobber
• ./mach build
• ./mach test devtools/client/inspector/computed/test/browser_computed_search-filter_context-menu.js

Will fail with

Unexpected Results
------------------
devtools/client/inspector/computed/test/browser_computed_search-filter_context-menu.js
  FAIL head.js import threw an exception - Error opening input stream (invalid filename?): chrome://mochitests/content/browser/devtools/client/debugger/test/mochitest/helpers/context.js

Regression from Bug 1543821. This bug started importing a debugger script in inspector/test/head.js. However this head.js is reused in a lot of other subsuites of the inspector, so devtools/client/debugger/test/mochitest/helpers/context.js should be whitelisted in every browser.ini that imports inspector/test/head.js.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1551167 - Move import of mochitest/helpers/context.js to test instead of head.js

Importing scripts in shared head files is hard to maintain because all it forces all browser ini that use the shared file to whitelist all its imports.
The debugger context helper is almost unused in the inspector, so it would be easier to just import it in the few tests that require it.
Also removed the whitelist entry in rules' browser.ini, no test in this suite used it.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/87e01787d465
Move import of mochitest/helpers/context.js to test instead of head.js r=pbro

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/87e01787d465